Detect invalid rustdoc test commands

[GuillaumeGomez]

Fixes #80570.

There are now errors displayed in case of bad command syntax:

---- [rustdoc] rustdoc/remove-url-from-headings.rs stdout ----

error: htmldocck failed!
status: exit code: 1
command: "/usr/bin/python" "/home/imperio/rust/rust/src/etc/htmldocck.py" "/home/imperio/rust/rust/build/x86_64-unknown-linux-gnu/test/rustdoc/remove-url-from-headings" "/home/imperio/rust/rust/src/test/rustdoc/remove-url-from-headings.rs"
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
3: Invalid command: `!@has`, (try with `@!has`)
	// !@has - '//a[@href="http://a.a"]'

Encountered 1 errors

r? @camelid

[camelid]

I can't review the implementation since I'm not familiar with the code and not familiar with the regex style, but the output looks good. Do you want to try adding a failing assertion (like @has ... 'someRandomText') and check that the test fails just to make sure this didn't break anything? And you might to re-assign to someone else to review the implementation.

Thanks for fixing this!

[camelid]

Maybe say

Suggested change

	'Invalid command: `!@{0}{1}`, (try with `@!{1}`)'.format(
	'Invalid command: `!@{0}{1}`, (help: try with `@!{1}`)'.format(

to be consistent with rustc suggestion? Not a big deal though.

[GuillaumeGomez]

Do you want to try adding a failing assertion (like @has ... 'someRandomText') and check that the test fails just to make sure this didn't break anything?

Automatically, it would require a lot of changes. So not sure if it's a good idea... However, just to confirm it works I did a small change and it failed as expected:

command: "/usr/bin/python" "/home/imperio/rust/rust/src/etc/htmldocck.py" "/home/imperio/rust/rust/build/x86_64-unknown-linux-gnu/test/rustdoc/generic-impl" "/home/imperio/rust/rust/src/test/rustdoc/generic-impl.rs"
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
6: @has check failed
	`XPATH PATTERN` did not match
	// @has foo/struct.Bar.html '//h4' 'yolo'

[GuillaumeGomez]

Also, I think @jyn514 was the last one to modify this file? Let's set him as reviewer then. :)

r? @jyn514

[jyn514]

@bors r+

Thanks!

[bors]

📌 Commit da3eef6 has been approved by jyn514

[camelid]

Automatically, it would require a lot of changes. So not sure if it's a good idea... However, just to confirm it works I did a small change and it failed as expected:

Yes, I meant to do a manual test just to make sure it's still picking up the assertions :)