rustdoc: Remove * intra-doc alias for pointer#80892
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 11, 2021
Merged
Conversation
It's not valid Rust code and it can easily be confused with a wildcard glob pattern or something else. People can always use `pointer` instead, so it's just removing an alias. It hasn't hit stable yet (I think it's still on nightly), so it's okay to remove it. (We can always add it back later if we change our mind too.)
camelid
added
A-intra-doc-links
Contributor
|
Some changes occurred in intra-doc-links. cc @jyn514 |
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ |
Collaborator
|
📌 Commit e98f11b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 11, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#80809 (Use standard formatting for "rust-call" ABI message) - rust-lang#80872 (Fix typo in source-based-code-coverage.md) - rust-lang#80878 (Add ABI argument to `find_mir_or_eval_fn`) - rust-lang#80881 ( Fix intra-doc links to `Self` and `crate` ) - rust-lang#80887 (log-color: Detect TTY based on stderr, not stdout) - rust-lang#80892 (rustdoc: Remove `*` intra-doc alias for `pointer`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
Member
Author
|
Wow, another race condition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not valid Rust code and it can easily be confused with a wildcard
glob pattern or something else. People can always use
pointerinstead,so it's just removing an alias.
It hasn't hit stable yet (I think it's still on nightly), so it's okay
to remove it. (We can always add it back later if we change our mind
too.)
r? @jyn514
cc #80885 (comment)