Make more traits of the From/Into family diagnostic items#81277

flip1995 · 2021-01-22T17:13:13Z

Following traits are now diagnostic items:

From (unchanged)
Into
TryFrom
TryInto

This also adds symbols for those items:

into_trait
try_from_trait
try_into_trait

Related: rust-lang/rust-clippy#6620 (comment)

Following traits are now diagnostic items: - `From` (unchanged) - `Into` - `TryFrom` - `TryInto` This also adds symbols for those items: - `into_trait` - `try_from_trait` - `try_into_trait`

rust-highfive · 2021-01-22T17:13:17Z

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

matthewjasper · 2021-01-24T23:23:32Z

@bors r+

bors · 2021-01-24T23:23:33Z

📌 Commit e25959b has been approved by matthewjasper

bors · 2021-01-25T03:16:39Z

⌛ Testing commit e25959b with merge 2b5468119d3037442a0e8f7a0dbd18acbdb82404...

rust-log-analyzer · 2021-01-25T03:41:05Z

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking crates-io v0.31.1 (/tmp/cargo/crates/crates-io)
error[E0283]: type annotations needed
   --> src/cargo/util/config/de.rs:530:63
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, env.as_ref()))
    |                                                           |   |
    |                                                           |   |
    |                                                           |   cannot infer type for type parameter `T` declared on the trait `AsRef`
    |                                                           this method call resolves to `&T`
    |
    = note: cannot satisfy `std::string::String: AsRef<_>`
help: use the fully qualified path for the potential candidates
    |
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<OsStr>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<std::path::Path>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<str>>::as_ref(env)))
    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
530 |                 seed.deserialize(Tuple2Deserializer(1i32, <std::string::String as AsRef<[u8]>>::as_ref(env)))

error: aborting due to previous error

For more information about this error, try `rustc --explain E0283`.

bors · 2021-01-25T03:43:21Z

💔 Test failed - checks-actions

flip1995 · 2021-01-25T09:59:19Z

CI failure seems unrelated? At least I can't think of a reason, why adding symbols and rustc_diagnostic_items produces a failure in src/cargo.

matthewjasper · 2021-01-25T12:23:57Z

cc #81378

matthewjasper · 2021-01-25T12:24:25Z

Tree is closed so I'll @bors r+ for when it reopens

bors · 2021-01-25T12:24:26Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: suppress errors in const eval during selection #81339

bors · 2021-01-25T12:24:27Z

📌 Commit e25959b has been approved by matthewjasper

bors · 2021-01-25T12:24:28Z

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

…jasper Make more traits of the From/Into family diagnostic items Following traits are now diagnostic items: - `From` (unchanged) - `Into` - `TryFrom` - `TryInto` This also adds symbols for those items: - `into_trait` - `try_from_trait` - `try_into_trait` Related: rust-lang/rust-clippy#6620 (comment)

Rollup of 13 pull requests Successful merges: - rust-lang#70904 (Stabilize `Seek::stream_position` (feature `seek_convenience`)) - rust-lang#79951 (Refractor a few more types to `rustc_type_ir` ) - rust-lang#80868 (Print failure message on all tests that should panic, but don't) - rust-lang#81062 (Improve diagnostics for Precise Capture) - rust-lang#81277 (Make more traits of the From/Into family diagnostic items) - rust-lang#81284 (Make `-Z time-passes` less noisy) - rust-lang#81379 (Improve URLs handling) - rust-lang#81416 (Tweak suggestion for missing field in patterns) - rust-lang#81426 (const_evaluatable: expand abstract consts in try_unify) - rust-lang#81428 (compiletest: Add two more unit tests) - rust-lang#81430 (add const_evaluatable_checked test) - rust-lang#81433 (const_evaluatable: stop looking into type aliases) - rust-lang#81445 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…jasper Make more traits of the From/Into family diagnostic items Following traits are now diagnostic items: - `From` (unchanged) - `Into` - `TryFrom` - `TryInto` This also adds symbols for those items: - `into_trait` - `try_from_trait` - `try_into_trait` Related: rust-lang/rust-clippy#6620 (comment)

Make more traits of the From/Into family diagnostic items

e25959b

Following traits are now diagnostic items: - `From` (unchanged) - `Into` - `TryFrom` - `TryInto` This also adds symbols for those items: - `into_trait` - `try_from_trait` - `try_into_trait`

rust-highfive assigned matthewjasper Jan 22, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 22, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 25, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2021

jonas-schievink mentioned this pull request Jan 25, 2021

Rollup of 8 pull requests #81385

Closed

This was referenced Jan 25, 2021

Rollup of 11 pull requests #81390

Closed

Rollup of 11 pull requests #81392

Closed

Rollup of 12 pull requests #81394

Closed

Dylan-DPC-zz mentioned this pull request Jan 27, 2021

Rollup of 9 pull requests #81423

Closed

Dylan-DPC-zz mentioned this pull request Jan 27, 2021

Rollup of 11 pull requests #81424

Closed

This was referenced Jan 27, 2021

Rollup of 15 pull requests #81435

Closed

Rollup of 15 pull requests #81437

Closed

This was referenced Jan 27, 2021

Rollup of 19 pull requests #81449

Closed

Rollup of 18 pull requests #81450

Closed

JohnTitor mentioned this pull request Jan 28, 2021

Rollup of 13 pull requests #81461

Merged

bors merged commit 70be5ce into rust-lang:master Jan 28, 2021

rustbot added this to the 1.51.0 milestone Jan 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make more traits of the From/Into family diagnostic items#81277