[beta] Rename panic_fmt lint to non_fmt_panic#81729
Closed
m-ou-se wants to merge 1 commit intorust-lang:betafrom
Closed
[beta] Rename panic_fmt lint to non_fmt_panic#81729m-ou-se wants to merge 1 commit intorust-lang:betafrom
panic_fmt lint to non_fmt_panic#81729m-ou-se wants to merge 1 commit intorust-lang:betafrom
Conversation
This comment has been minimized.
This comment has been minimized.
a9c76cc to
15ff879
Compare
This comment has been minimized.
This comment has been minimized.
15ff879 to
2dfdbe1
Compare
Collaborator
|
☔ The latest upstream changes (presumably #81761) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
I would like to see this in 1.50, so beta accepting, but looks like there are some conflicts - @m-ou-se could you resolve those? |
Member
|
If this doesn't get into beta then I think the behavior of doing nothing or silent acceptance etc is fine and doesn't worry me too much. We can always rename the lint without too much hassle IMO. |
2dfdbe1 to
bfa0668
Compare
Member
Author
panic_fmt lint to non_fmt_panicpanic_fmt lint to non_fmt_panic
Member
|
@bors r+ rollup=never |
Collaborator
|
📌 Commit bfa0668 has been approved by |
Collaborator
|
⌛ Testing commit bfa0668 with merge 18dc1d220d7db12d529bc1a51fc87cab54e9edf4... |
Collaborator
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
Member
Author
|
@bors retry |
Contributor
Merged
Member
Author
|
@ehuss thanks :) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2021
[beta] backports This backports: * CI: only copy python.exe to python3.exe if the latter does not exist rust-lang#81762 * Make hitting the recursion limit in projection non-fatal rust-lang#81055 * Remove incorrect `delay_span_bug` rust-lang#81532 * introduce future-compatibility warning for forbidden lint groups rust-lang#81556 * Update cargo rust-lang#81755 * rustdoc: Fix visibility of trait and impl items rust-lang#81288 * Work around missing -dev packages in solaris docker image. rust-lang#81229 * Update LayoutError/LayoutErr stability attributes rust-lang#81767 * Revert 78373 ("dont leak return value after panic in drop") rust-lang#81257 * Rename `panic_fmt` lint to `non_fmt_panic` rust-lang#81729
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While extending the recently-added
panic_fmtlint, we're renaming it tonon_fmt_panicto follow the lint naming guidelines: #81645The
panic_fmtlint has not yet reached stable. If we don't do anything,#[allow(panic_fmt)]will work in 1.50, but give an 'unknown lint' warning in 1.51 later. I'm not sure if this warrants a backport to beta, and if it does, whether it'd be best to just rename the lint (as this PR does) or entirely remove the lint from beta. Opening this PR againstbetaas a possible option. Feel free to close or suggest a different course of action. :)r? @Mark-Simulacrum