Push a char instead of a str with len one into a String#82022
Push a char instead of a str with len one into a String#82022bors merged 1 commit intorust-lang:masterfrom
char instead of a str with len one into a String#82022Conversation
rustbot
added
C-cleanup
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit fda71d6 has been approved by |
bors
added
S-waiting-on-bors
|
Just curious - the push_str handles string to string data so no encoding needed, in most cases using |
Check: rust-lang/rust-clippy#5875 |
|
Since we're working on a literal here, it get's optimized down to basically the same assembly anyway. |
Push a `char` instead of a `str` with len one into a String `@rustbot` modify labels +C-cleanup +T-compiler
Rollup of 10 pull requests Successful merges: - rust-lang#79775 (Fix injected errors when running doctests on a crate named after a keyword) - rust-lang#81012 (Stabilize the partition_point feature) - rust-lang#81479 (Allow casting mut array ref to mut ptr) - rust-lang#81506 (HWAddressSanitizer support) - rust-lang#81741 (Increment `self.index` before calling `Iterator::self.a.__iterator_ge…) - rust-lang#81850 (use RWlock when accessing os::env) - rust-lang#81911 (GAT/const_generics: Allow with_opt_const_param to return GAT param def_id) - rust-lang#82022 (Push a `char` instead of a `str` with len one into a String) - rust-lang#82023 (Remove unnecessary lint allow attrs on example) - rust-lang#82030 (Use `Iterator::all` instead of open-coding it) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
8 participants
@rustbot modify labels +C-cleanup +T-compiler