Added tests to drain an empty vec#82050
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 13, 2021
Merged
Conversation
Discovered this kind of issue in an unrelated library. The author copied the tests from here and AFAIK, there are no tests for this particular case. Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
Contributor
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit fa9af6a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#81811 (Fix doc test for Vec::retain(), now passes clippy::eval_order_dependence) - rust-lang#81900 (Organize trait test files) - rust-lang#81995 (Fix suggestion to introduce explicit lifetime) - rust-lang#82031 (Drop an unnecessary intermediate variable) - rust-lang#82033 (Refactor `get_word_attr` to return only `Option`) - rust-lang#82040 (Add test to prevent src link regression) - rust-lang#82041 (Add docs for shared_from_slice From impls) - rust-lang#82050 (Added tests to drain an empty vec) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered this kind of issue in an unrelated library.
The author copied the tests from here and AFAIK, there are no tests for this particular case.
cmazakas/minivec#19
Signed-off-by: Hanif Bin Ariffin hanif.ariffin.4326@gmail.com