Skip to content

Add more proc-macro attribute tests#82643

Merged
bors merged 1 commit intorust-lang:masterfrom
Aaron1011:test-macro-attrs
Mar 1, 2021
Merged

Add more proc-macro attribute tests#82643
bors merged 1 commit intorust-lang:masterfrom
Aaron1011:test-macro-attrs

Conversation

@Aaron1011
Copy link
Contributor

@Aaron1011 Aaron1011 commented Feb 28, 2021

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2021
@Aaron1011 Aaron1011 mentioned this pull request Feb 28, 2021
Merged
@petrochenkov
Copy link
Contributor

petrochenkov commented Feb 28, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 28, 2021

📌 Commit d7d77d80395998dfd30ecd7e25c31d9d492b74a9 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2021
@Aaron1011
Copy link
Contributor Author

Aaron1011 commented Feb 28, 2021

@bors r-

I'm going to add a few of the unusual inner attribute cases from #82608

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 28, 2021
@Aaron1011
Copy link
Contributor Author

Aaron1011 commented Feb 28, 2021

@petrochenkov: I've added two new tests to src/test/ui/proc-macro/inner-attrs.rs. This is now ready to merge

petrochenkov
petrochenkov reviewed Feb 28, 2021
View reviewed changes
@Aaron1011
Copy link
Contributor Author

Aaron1011 commented Feb 28, 2021

@petrochenkov: I've added more tests

@Aaron1011 Aaron1011 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2021
@petrochenkov
Copy link
Contributor

petrochenkov commented Feb 28, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 28, 2021

📌 Commit 35491753ea80fe6c938881d8e3cc0a86ad6f938b has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2021
@bors
Copy link
Collaborator

bors commented Feb 28, 2021

⌛ Testing commit 35491753ea80fe6c938881d8e3cc0a86ad6f938b with merge 9b9ec046f68773bac347fe0c5ba598929f19f5c5...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Mar 1, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2021
@Aaron1011
Copy link
Contributor Author

Aaron1011 commented Mar 1, 2021

I had forgotten to add the proper header to the new tests:

#![no_std] // Don't load unnecessary hygiene information from std
extern crate std;

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Mar 1, 2021

📌 Commit 8aed5b4 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2021
@JohnTitor JohnTitor mentioned this pull request Mar 1, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2021
@bors
Auto merge of rust-lang#82654 - JohnTitor:rollup-nkcdkzp, r=JohnTitor
d2731d8 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#82309 (Propagate RUSTDOCFLAGS in the environment when documenting)
 - rust-lang#82403 (rustbuild: print out env vars on verbose rustc invocations)
 - rust-lang#82507 (Rename the `tidy` binary to `rust-tidy`)
 - rust-lang#82531 (Add GUI tests)
 - rust-lang#82532 (Add `build.print_step_rusage` to config.toml)
 - rust-lang#82543 (fix env var name in CI)
 - rust-lang#82622 (Propagate `--test-args` for `x.py test src/tools/cargo`)
 - rust-lang#82628 (Try to clarify GlobalAlloc::realloc documentation comment.)
 - rust-lang#82630 (Fix a typo in the `find_anon_type` doc)
 - rust-lang#82643 (Add more proc-macro attribute tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e2d8efb into rust-lang:master Mar 1, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.52.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Aaron1011 @petrochenkov @bors @rust-log-analyzer @rust-highfive @rustbot