Custom error on literal names from other languages#82989
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 15, 2021
Merged
Custom error on literal names from other languages#82989bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jfrimmel
suggested changes
Mar 11, 2021
Contributor
jfrimmel
left a comment
jfrimmel
left a comment
There was a problem hiding this comment.
In general I support this help messages, but I think that "literal" is not the right word in this case.
"Rust type" might be better.
fbstj
reviewed
Mar 12, 2021
jfrimmel
approved these changes
Mar 12, 2021
varkor
reviewed
Mar 13, 2021
varkor
added
S-waiting-on-author
Contributor
Author
|
@rustbot label -S-waiting-on-author +S-waiting-on-review |
rustbot
added
S-waiting-on-review
varkor
reviewed
Mar 15, 2021
Contributor
varkor
left a comment
varkor
left a comment
There was a problem hiding this comment.
Thanks, this looks good! If you could squash the commits after making the final changes, it should be good to go.
This detects all Java literal types and all single word C data types, and suggests the corresponding Rust literal type.
syvb
force-pushed
the
other-lang-literal-errors
branch
from
f97a978 to
5eae9af
Compare
Contributor
Collaborator
|
📌 Commit 5eae9af has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 15, 2021
… r=varkor Custom error on literal names from other languages This detects all Java literal types and all single word C data types, and suggests the corresponding Rust literal type.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 15, 2021
… r=varkor Custom error on literal names from other languages This detects all Java literal types and all single word C data types, and suggests the corresponding Rust literal type.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 15, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#82989 (Custom error on literal names from other languages) - rust-lang#83054 (Validate rustc_layout_scalar_valid_range_{start,end} attributes) - rust-lang#83098 (Find more invalid doc attributes) - rust-lang#83108 (Remove unused `opt_local_def_id_to_hir_id` function) - rust-lang#83110 (Fix typos in `library/core/src/ptr/mod.rs` and `library/std/src/sys_common/thread_local_dtor.rs`) - rust-lang#83113 (Minor refactoring in try_index_step) - rust-lang#83127 (Introduce `proc_macro_back_compat` lint, and emit for `time-macros-impl`) - rust-lang#83132 (Don't encode file information for span with a dummy location) - rust-lang#83141 (:arrow_up: rust-analyzer) - rust-lang#83144 (Introduce `rustc_interface::interface::Config::parse_sess_created` callback) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This detects all Java literal types and all single word C data types, and suggests the corresponding Rust literal type.