Tell GitHub to highlight config.toml.example as TOML#83431
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 27, 2021
Merged
Tell GitHub to highlight config.toml.example as TOML#83431bors merged 1 commit intorust-lang:masterfrom
config.toml.example as TOML#83431bors merged 1 commit intorust-lang:masterfrom
Conversation
This should be a nice small quality of life improvement when looking at `config.toml.example` on GitHub or looking at diffs of it in PRs.
camelid
added
the
A-meta
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
I wish we could just rename it to config.example.toml - @Mark-Simulacrum do you think that would break too many scripts? Maybe we could make config.toml.example a symlink somehow? |
Member
|
Hm, seeing as we don't expect people to edit it directly really, why do you think such a change is a good idea? It does have some churn cost and doesn't seem particularly meaningful to humans? I'm inclined to just approve this PR (which seems like a small win). |
Member
|
This PR doesn't fix it for editing with vim or other editors I think.
Sure, this is definitely a strict improvement - I just think it would be nice to make the fix more general. I'm sympathetic to not wanting churn though. |
Contributor
|
i still prefer config.toml.example rather than config.example.toml because:
|
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit b3ae90b has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 26, 2021
…s, r=Mark-Simulacrum Tell GitHub to highlight `config.toml.example` as TOML This should be a nice small quality of life improvement when looking at `config.toml.example` on GitHub or looking at diffs of it in PRs.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 27, 2021
…s, r=Mark-Simulacrum Tell GitHub to highlight `config.toml.example` as TOML This should be a nice small quality of life improvement when looking at `config.toml.example` on GitHub or looking at diffs of it in PRs.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#83239 (Remove/replace some outdated crates from the dependency tree) - rust-lang#83328 (Fixes to inline assmebly tests) - rust-lang#83343 (Simplify and fix byte skipping in format! string parser) - rust-lang#83388 (Make # pretty print format easier to discover) - rust-lang#83431 (Tell GitHub to highlight `config.toml.example` as TOML) - rust-lang#83508 (Use the direct link to the platform support page) - rust-lang#83511 (compiletest: handle llvm_version with suffix like "12.0.0libcxx") - rust-lang#83524 (Document that the SocketAddr memory representation is not stable) - rust-lang#83525 (fix doc comment for `ty::Dynamic`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a nice small quality of life improvement when looking at
config.toml.exampleon GitHub or looking at diffs of it in PRs.