Skip to content

Add hir::GenericArg::Infer#83484

Merged
bors merged 3 commits intorust-lang:masterfrom
JulianKnodt:infer
Jul 27, 2021
Merged

Add hir::GenericArg::Infer#83484
bors merged 3 commits intorust-lang:masterfrom
JulianKnodt:infer

Conversation

@JulianKnodt
Copy link
Contributor

@JulianKnodt JulianKnodt commented Mar 25, 2021 •
edited
Loading

In order to extend inference to consts, make an Infer type on hir::GenericArg.

petrochenkov
petrochenkov reviewed Mar 25, 2021
View reviewed changes
@JulianKnodt JulianKnodt changed the title [WIP] Add hir::GenericArg::Infer Add hir::GenericArg::Infer Mar 27, 2021
@JulianKnodt JulianKnodt marked this pull request as ready for review March 27, 2021 05:10
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JulianKnodt JulianKnodt force-pushed the infer branch 4 times, most recently from 9c81041 to 5d2b04a Compare March 27, 2021 17:37
@JulianKnodt
Copy link
Contributor Author

JulianKnodt commented Mar 27, 2021 •
edited
Loading

r? @lcnr
I'm not sure if you intended for const inference to work here yet, I didn't add it (but can if it's already possible)

@JulianKnodt
Copy link
Contributor Author

JulianKnodt commented Mar 27, 2021

@rustbot label: +S-waiting-on-review

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed Mar 29, 2021
View reviewed changes
@lcnr
Copy link
Contributor

lcnr commented Jul 27, 2021

@bors r=oli-obk,lcnr

@bors
Copy link
Collaborator

bors commented Jul 27, 2021

📌 Commit 8759f00 has been approved by oli-obk,lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2021
@lcnr
Copy link
Contributor

lcnr commented Jul 27, 2021

while I assume it won't matter, better safe than sorry
@bors rollup=never

@bors
Copy link
Collaborator

bors commented Jul 27, 2021

⌛ Testing commit 8759f00 with merge cc4cb3f8f09c50d50407106fee4b008df6e11b1e...

@bors
Copy link
Collaborator

bors commented Jul 27, 2021

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jul 27, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2021
@lcnr
Copy link
Contributor

lcnr commented Jul 27, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2021
@bors
Copy link
Collaborator

bors commented Jul 27, 2021

⌛ Testing commit 8759f00 with merge fd853c0...

@bors
Copy link
Collaborator

bors commented Jul 27, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk,lcnr
Pushing fd853c0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 27, 2021
@bors bors merged commit fd853c0 into rust-lang:master Jul 27, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 27, 2021
@JulianKnodt JulianKnodt deleted the infer branch July 27, 2021 19:37
This was referenced Jul 27, 2021
Merged
Merged
Merged
Merged
Merged
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 29, 2021
@bors
Auto merge of rust-lang#83484 - JulianKnodt:infer, r=oli-obk,lcnr
ea988af 
Add hir::GenericArg::Infer

In order to extend inference to consts, make an Infer type on hir::GenericArg.
@lcnr lcnr added the A-const-generics Area: const generics (parameters and arguments) label Dec 11, 2021
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
@fluiderson fluiderson mentioned this pull request May 5, 2025
Open
@BoxyUwU BoxyUwU mentioned this pull request May 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk left review comments

@petrochenkov petrochenkov petrochenkov left review comments

@lcnr lcnr lcnr left review comments

+1 more reviewer

@varkor varkor varkor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@oli-obk oli-obk

Labels

A-const-generics Area: const generics (parameters and arguments) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JulianKnodt @rust-log-analyzer @bors @varkor @lcnr @oli-obk @petrochenkov @crlf0710 @rustbot