Use an SVG image for clipboard instead of unicode character#85118
Use an SVG image for clipboard instead of unicode character#85118bors merged 1 commit intorust-lang:masterfrom
Conversation
GuillaumeGomez
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
|
We should really switch to using an SVG sprite sheet for rustdoc icons, so all three icons can be loaded from one file, and so that we can inherit theme colors. |
|
They currently keep their color, whatever the theme. |
That's a problem
|
|
It currently goes back to the old text clipboard icon after clicking (pretend this is a gif, I don't have a gif recorder on this pc 😀):
|
|
Oh right! Good catch! |
GuillaumeGomez
force-pushed
the
clipboard-svg
branch
from
06bf2f9 to
7450f70
Compare
|
Fixed all the mentionned issues. |
|
Looks good enough to start, @notriddle do you wanna open an issue about maybe moving to an SVG sprite sheet? I guess the major thing that would need checking is browser compatibility. @bors r+ |
|
📌 Commit 7450f70 has been approved by |
bors
added
S-waiting-on-bors
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#84465 (rustdoc: Implement `is_primitive` in terms of `primitive_type()`) - rust-lang#85118 (Use an SVG image for clipboard instead of unicode character) - rust-lang#85148 (Fix source code line number display and make it clickable again) - rust-lang#85152 (Adjust target search algorithm for rustlib path) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
This made the clipboard icon much larger and more distracting: before
after
I felt concerned about it being too conspicuous before, but now it's even more so. Is there a way to make it smaller or lighter? The docs.rs one is only shown for the crate root, not for every single item in the crate. |
|
I voluntarily made it bigger actually. XD |
|
So could you make it smaller again? ;) |
|
Hmm, I don't see such a small icon on older docs, it looks like it's using system fonts so depends on what font is selected.
That said the new icon definitely is a bit bigger, I kinda like something like dropping the border and reducing the opacity (with some kind of hover state). Having an inline "button" border looks quite weird to me.
|
|
Hum... Maybe @jsha has an opinion here? I personally don't mind changing to any of what was suggested so I'm definitely not the good person to pick one. |
|
I like @Nemo157's proposal with the smallish, unobtrusive icon. |
|
Giving it a try then! |
…provement, r=jsha Improve display for "copy-path" button, making it more discreet As suggested by `@Nemo157` [here](rust-lang#85118 (comment)):       r? `@jsha`
8 participants
Linked to rust-lang/docs.rs#1394.
cc @jsha
r? @Nemo157