Account for incorrect impl Foo<const N: ty> {} syntax#85346
Merged
bors merged 3 commits intorust-lang:masterfrom Nov 25, 2021
Merged
Account for incorrect impl Foo<const N: ty> {} syntax#85346bors merged 3 commits intorust-lang:masterfrom
impl Foo<const N: ty> {} syntax#85346bors merged 3 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Error message looks good to me! @bors r+ |
Collaborator
|
📌 Commit 714f0086c1805c51e3937caa3312bfd8569ca587 has been approved by |
bors
added
S-waiting-on-bors
varkor
added
the
A-const-generics
Collaborator
|
⌛ Testing commit 714f0086c1805c51e3937caa3312bfd8569ca587 with merge 42656b00254b737e66b0e4bcb7ebc12bde066049... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bstrie
added
S-waiting-on-author
Collaborator
|
☔ The latest upstream changes (presumably #86080) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
JohnCSimon
added
S-waiting-on-author
Contributor
|
cc @estebank: this is waiting on a rebase. |
crlf0710
added
S-waiting-on-author
Contributor
Author
|
@bors r=varkor |
Collaborator
|
📌 Commit 332a327394286cb3d0186a34fc634a5bb110729a has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 332a327394286cb3d0186a34fc634a5bb110729a with merge e1fa3a00922b6beb11caed1133eaf12796d8159d... |
Collaborator
|
📌 Commit 46502de0bccc789be9d6862f5d4c78e667cdfd9a has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
issue-84946
branch
from
46502de to
505b09e
Compare
Contributor
Author
|
Forgot to @bors r=nagisa,varkor |
Collaborator
|
📌 Commit 505b09e has been approved by |
Collaborator
|
⌛ Testing commit 505b09e with merge 9fa96d7a643326093ee155a054874243fa007326... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
Author
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Nov 25, 2021
Collaborator
|
Finished benchmarking commit (c6eda7d): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
calebcartwright
pushed a commit
to calebcartwright/rust
that referenced
this pull request
Dec 3, 2021
Use the available Generics span field to avoid issues with `T: Fn()` bounds. This is necessary to land rust-lang#85346.
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #84946