Merged
Conversation
…ounding complexity to current implementation
The makes the code for handling "auto-hide" settings more consistent.
impl FromStr for proc_macro::Literal
Note that unlike `impl FromStr for proc_macro::TokenStream`, this impl does not permit whitespace or comments. The input string must consist of nothing but your literal.
- `"1".parse::<Literal>()` ⟶ ok
- `"1.0".parse::<Literal>()` ⟶ ok
- `"'a'".parse::<Literal>()` ⟶ ok
- `"\"\n\"".parse::<Literal>()` ⟶ ok
- `"0 1".parse::<Literal>()` ⟶ LexError
- `" 0".parse::<Literal>()` ⟶ LexError
- `"0 ".parse::<Literal>()` ⟶ LexError
- `"/* comment */0".parse::<Literal>()` ⟶ LexError
- `"0/* comment */".parse::<Literal>()` ⟶ LexError
- `"0// comment".parse::<Literal>()` ⟶ LexError
---
## Use case
```rust
let hex_int: Literal = format!("0x{:x}", int).parse().unwrap();
```
The only way this is expressible in the current API is significantly worse.
```rust
let hex_int = match format!("0x{:x}", int)
.parse::<TokenStream>()
.unwrap()
.into_iter()
.next()
.unwrap()
{
TokenTree::Literal(literal) => literal,
_ => unreachable!(),
};
```
Add method-toggle to <details> for methods The makes the code for handling "auto-hide" settings more consistent. Demo at https://hoffman-andrews.com/rust/hoist-classes/std/string/struct.String.html Fixes rust-lang#84829
…ou-se Expose `Concurrent` (private type in public i'face) rust-lang#53410 introduced experimental support for custom test frameworks. Such frameworks may wish to build upon `library/test` by calling into its publicly exposed API (which I entirely understand is wholly unstable). However, any that wish to call `test::run_test` cannot currently do so because `test::options::Concurrent` (the type of its `concurrent` parameter) is not publicly exposed.
adding time complexity for partition_in_place iter method I feel that one thing missing from rust docs compared to cpp references is existence of time complexity for all methods and functions. While it would be humongous task to include it for everything in single go, it is still doable if we as community keep on adding it in relevant places as and when we find them. This PR adds the time complexity for partition_in_place method in iter.
…_type, r=davidtwco Add diagnostic item to `CStr` Required for clippy issue: rust-lang/rust-clippy#7145
…=dtolnay Fix UB in documented example for `ptr::swap` Compare [this (short) discussion on zulip](https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Pointers.20to.20overlapping.20arrays) (or [in the archive](https://zulip-archive.rust-lang.org/122651general/92017Pointerstooverlappingarrays.html), if you don’t have an account). ``@rustbot`` label T-doc T-libs
Fix invalid CSS rules for a:hover When hovering some links:   It is a side-effect from rust-lang#84462. r? ```@jsha```
CTFE Machine: do not expose Allocation `Memory` is careful now to not expose direct access to `Allocation`, but this one slipped through. r? ``@oli-obk``
Member
Author
|
@bors r+ p=5 |
Collaborator
|
📌 Commit 9fa15ff has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 9fa15ff with merge a5b887dd727eec12f93ac1695cf446a26b3220cb... |
Contributor
Haha, broken rollup text via inlined tags. Perhaps text should be escaped before printing here? |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
A bugreport against the bot (at https://github.com/rust-lang/homu) would be welcome. :) |
Member
Author
Might well be an intermittent problem? @bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
May 25, 2021
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
May 30, 2021
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
May 31, 2021
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
May 31, 2021
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
Jun 4, 2021
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
Jun 12, 2021
cynecx
added a commit
to cynecx/rust-analyzer
that referenced
this pull request
Jun 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Details
for methods)Concurrent(private type in public i'face) #85287 (ExposeConcurrent(private type in public i'face))CStr#85439 (Add diagnostic item toCStr)ptr::swap#85464 (Fix UB in documented example forptr::swap)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup