Make closures inherit their parent's "safety context"#85607
Merged
bors merged 2 commits intorust-lang:masterfrom May 28, 2021
Merged
Make closures inherit their parent's "safety context"#85607bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
f0744a1 to
7e90a53
Compare
This comment has been minimized.
This comment has been minimized.
7e90a53 to
3f1fb86
Compare
Contributor
Author
|
@nikomatsakis This is ready for review now |
nikomatsakis
requested changes
May 27, 2021
Contributor
nikomatsakis
left a comment
There was a problem hiding this comment.
Are there no tests for this/
Contributor
Author
|
Whoops you're right, I forgot |
3f1fb86 to
f996001
Compare
Contributor
Author
|
@nikomatsakis Pushed the tests. To track the tests that were fixed by this, I ran all the test suite with
Making progress :) |
This comment has been minimized.
This comment has been minimized.
f996001 to
d1f0e9f
Compare
nikomatsakis
approved these changes
May 27, 2021
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit d1f0e9f has been approved by |
Collaborator
|
⌛ Testing commit d1f0e9f with merge 6676f8aa363db6b8bb1b6494cd0a33ca24a04d32... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
Contributor
Author
|
Probably spurious failure? |
Contributor
|
@bors retry |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/project-thir-unsafeck#9,
blocked on #85273.r? @nikomatsakis