Add proc_macro::Span::{before, after}.#86165
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 11, 2021
Merged
Conversation
m-ou-se
added
T-libs-api
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
m-ou-se
commented
Jun 9, 2021
petrochenkov
approved these changes
Jun 9, 2021
Member
|
Part of me would prefer this be called Would it makes sense to repurpose these names and provide a generalized Just a random thought I had from a usability perspective; I could certainly get accustomed to the before/after naming. |
JohnCSimon
added
S-waiting-on-review
joelpalmer
added
S-waiting-on-review
3 tasks
Member
Author
|
@jhpratt Since a span is not a point/location but a range, calling it start and end doesn't feel entirely accurate to me. |
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
Member
Author
|
r? @dtolnay |
dtolnay
approved these changes
Sep 9, 2021
Member
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
This API looks good to me as implemented.
Member
|
@bors r+ |
Collaborator
|
📌 Commit f9be6cd has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2021
…arth Rollup of 15 pull requests Successful merges: - rust-lang#85200 (Ignore derived Clone and Debug implementations during dead code analysis) - rust-lang#86165 (Add proc_macro::Span::{before, after}.) - rust-lang#87088 (Fix stray notes when the source code is not available) - rust-lang#87441 (Emit suggestion when passing byte literal to format macro) - rust-lang#88546 (Emit proper errors when on missing closure braces) - rust-lang#88578 (fix(rustc): suggest `items` be borrowed in `for i in items[x..]`) - rust-lang#88632 (Fix issues with Markdown summary options) - rust-lang#88639 (rustdoc: Fix ICE with `doc(hidden)` on tuple variant fields) - rust-lang#88667 (Tweak `write_fmt` doc.) - rust-lang#88720 (Rustdoc coverage fields count) - rust-lang#88732 (RustWrapper: avoid deleted unclear attribute methods) - rust-lang#88742 (Fix table in docblocks) - rust-lang#88776 (Workaround blink/chromium grid layout limitation of 1000 rows) - rust-lang#88807 (Fix typo in docs for iterators) - rust-lang#88812 (Fix typo `option` -> `options`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…tolnay
Add proc_macro::Span::{before, after}.
This adds `proc_macro::Span::before()` and `proc_macro::Span::after()` to get a zero width span at the start or end of the span.
These are equivalent to rustc's `Span::shrink_to_lo()` and `Span::shrink_to_hi()` but with a less cryptic name. They are useful when generating diagnostlics like "missing \<thing\> after \<thing\>".
E.g.
```rust
syn::Error::new(ident.span().after(), "missing `:` after field name").into_compile_error()
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
proc_macro::Span::before()andproc_macro::Span::after()to get a zero width span at the start or end of the span.These are equivalent to rustc's
Span::shrink_to_lo()andSpan::shrink_to_hi()but with a less cryptic name. They are useful when generating diagnostlics like "missing <thing> after <thing>".E.g.