Don't lint :pat when re-parsing a macro from another crate.#86574
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 25, 2021
Merged
Don't lint :pat when re-parsing a macro from another crate.#86574bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
m-ou-se
added
A-macros
Contributor
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
m-ou-se
force-pushed
the
or-pattern-lint-fix
branch
from
2c31d9a to
4df9741
Compare
Member
Author
nikomatsakis
approved these changes
Jun 23, 2021
Contributor
|
@bors r+ Seems simple enough. |
Collaborator
|
📌 Commit 4df97419ee19968f7afee2d1307f38b52e267ef7 has been approved by |
bors
added
S-waiting-on-bors
Contributor
bors
added
S-waiting-on-author
Contributor
|
Good catch @petrochenkov =) I had thought about assigning you to r+, but I didn't want to overload you. |
rylev
reviewed
Jun 24, 2021
Contributor
|
r=me with #86574 (comment) addressed and commits squashed. |
m-ou-se
force-pushed
the
or-pattern-lint-fix
branch
from
218ca9e to
06db210
Compare
Member
Author
|
@bors r=petrochenkov |
Collaborator
|
📌 Commit 06db210 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compile_macrois used both when compiling the original definition in the crate that defines it, and to compile the macro when loading it when compiling a crate that uses it. We should only emit lints in the first case.This adds a
is_definition: boolto pass this information in, so we don't warn about things that only concern the definition site.Fixes #86567