rustdoc: Move label to symbol#86594
Merged
bors merged 2 commits intorust-lang:masterfrom Jun 29, 2021
Merged
Conversation
JohnTitor
added
the
S-waiting-on-review
Contributor
Author
|
Thanks! Bors seems to be busy. |
Contributor
Author
|
I uploaded a demo for the PR: https://data.estada.ch/rustdoc-nightly_2336406b38_2021-06-24/rustdoc_demo/mod1/index.html |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #85651) made this pull request unmergeable. Please resolve the merge conflicts. |
dns2utf8
force-pushed
the
move_label_to_symbol
branch
from
f15ff16 to
3484631
Compare
Contributor
Author
|
During testing I noticed that rustdoc-gui tests were running sequentially taking ~40 seconds to complete. |
Contributor
Author
|
I hid the passing tests and only show the failed ones in alphabetical order: |
Member
|
Still: please move the runner changes into another PR so I can already merge the fixes? :) We can debate more at ease on another 100%-focused PR about this. |
Contributor
Author
|
ah, overlooked that 😅 let me reorganise it |
dns2utf8
force-pushed
the
move_label_to_symbol
branch
from
3abca47 to
0f3ea4d
Compare
dns2utf8
force-pushed
the
move_label_to_symbol
branch
from
1864997 to
84374ed
Compare
This comment has been minimized.
This comment has been minimized.
dns2utf8
force-pushed
the
move_label_to_symbol
branch
from
84374ed to
0f2e137
Compare
GuillaumeGomez
approved these changes
Jun 29, 2021
Member
|
Thanks! @bors: r+ |
Collaborator
|
📌 Commit 0f2e137 has been approved by |
bors
added
S-waiting-on-bors
Contributor
Author
|
You are welcome! 🥳 |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
dns2utf8
added a commit
to dns2utf8/rust
that referenced
this pull request
Jul 1, 2021
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 1, 2021
… r=GuillaumeGomez Enable the tests developed with rust-lang#86594 This PR requires `browser-ui-test@0.4.1`. Can we centralise the version number somehow and maybe automatically install it when tests are run? r? `@GuillaumeGomez`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2021
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#86558 (Add suggestions for "undefined reference" link errors) - rust-lang#86616 (rustc_span: Explicitly handle crates that differ from package names) - rust-lang#86652 (Add support for leaf function frame pointer elimination) - rust-lang#86666 (Fix misleading "impl Trait" error) - rust-lang#86762 (mailmap: Add my work email address) - rust-lang#86773 (Enable the tests developed with rust-lang#86594) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #86578 depends on #85651
r? @GuillaumeGomez
Screenshot of mobile
Screenshot on desktop