Only include lint in future_incompatible lint group if not an edition lint#86689
Merged
bors merged 2 commits intorust-lang:masterfrom Jun 30, 2021
Merged
Only include lint in future_incompatible lint group if not an edition lint#86689bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
m-ou-se
approved these changes
Jun 28, 2021
m-ou-se
added
A-diagnostics
nikomatsakis
requested changes
Jun 28, 2021
nikomatsakis
approved these changes
Jun 29, 2021
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit f0d7280 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to #86330 - this only includes lints annotated with
FutureIncompatibleInfoin thefuture_incompatibilelint group if the future compatibility is not tied to an edition.We probably want to rename
FutureIncompatibleInfoto something else since this type is now used to indicate future breakages of all kinds (even those that happen in editions). I'd prefer to do that in a separate PR though.r? @nikomatsakis