Skip to content

Add long explanation for E0757#87342

Merged
bors merged 3 commits intorust-lang:masterfrom
midgleyc:add-E0757-long
Jul 21, 2021
Merged

Add long explanation for E0757#87342
bors merged 3 commits intorust-lang:masterfrom
midgleyc:add-E0757-long

Conversation

@midgleyc
Copy link
Contributor

@midgleyc midgleyc commented Jul 21, 2021

Helps with #61137

@rust-highfive
Copy link
Contributor

rust-highfive commented Jul 21, 2021

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

rust-highfive commented Jul 21, 2021

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2021
GuillaumeGomez
GuillaumeGomez reviewed Jul 21, 2021
View reviewed changes
compiler/rustc_error_codes/src/error_codes/E0757.md Outdated
}
```

As `const` has a stricter set of requirements than `pure`, remove the `ffi_pure`
Copy link
Member

@GuillaumeGomez GuillaumeGomez Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ffi_const you mean? Also, is there a documentation we could link to by any chance?

Copy link
Contributor Author

@midgleyc midgleyc Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I mean const. const and pure are C function attributes (e.g. see Common Function Attributes). Annotating a function with ffi_const says that it's C const, and annotating with ffi_pure says that it's C pure. I could use ffi_const and ffi_pure instead, but I felt it was more readable to lift the covers up to what they mean in GCC or other C compilers. What do you think?

I could link to ffi-pure and ffi-const from the unstable rust book. The former does mention that #[ffi_const] provides stronger guarantees, which implies that it's stricter.

Copy link
Member

@GuillaumeGomez GuillaumeGomez Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ffi_* instead then. If I asked the questions, others will wonder about the same thing as well. Please add the links as well then.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 21, 2021

Thanks!

@bors: r+ rollup squash

@bors
Copy link
Collaborator

bors commented Jul 21, 2021

📌 Commit 8b75fec has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 21, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2021
@bors
Auto merge of rust-lang#87347 - GuillaumeGomez:rollup-ke92xxc, r=Guil…
05f2326 
…laumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#87187 (Fix NixOS detection)
 - rust-lang#87206 (avoid temporary vectors/reuse iterators)
 - rust-lang#87230 (Fix docblock <table> overflow)
 - rust-lang#87273 (Recognize bounds on impls as const bounds)
 - rust-lang#87279 (Add comments explaining the unix command-line argument support.)
 - rust-lang#87301 (Fix typo in compile.rs)
 - rust-lang#87311 (Get back the more precise suggestion spans of old regionck)
 - rust-lang#87321 (Add long explanation for E0722)
 - rust-lang#87342 (Add long explanation for E0757)

Failed merges:

 - rust-lang#87270 (Don't display <table> in item summary)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3a8bc0d into rust-lang:master Jul 21, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 21, 2021
@midgleyc midgleyc deleted the add-E0757-long branch July 21, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@jackh726 jackh726

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

6 participants

@midgleyc @rust-highfive @GuillaumeGomez @bors @jackh726 @rustbot