Prepare beta 1.55.0#87508

emilyalbini · 2021-07-27T10:17:44Z

Included backports:

Reverted:

Add check to ensure error code explanations are not removed anymore even if not emitted #86623

cc @rust-lang/release @Mark-Simulacrum

rust-highfive · 2021-07-27T10:17:47Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2021-07-27T10:17:47Z

⚠️ Warning ⚠️

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

emilyalbini · 2021-07-27T10:17:57Z

@bors r+ p=100 rollup=never

bors · 2021-07-27T10:17:58Z

📌 Commit 56397e9 has been approved by pietroalbini

Part of rust-lang#87059 Partially reverts rust-lang#84703 Preview at: https://notriddle.com/notriddle-rustdoc-test/real-headers/std/index.html

emilyalbini · 2021-07-27T10:24:16Z

Also included backports.

@bors r+

bors · 2021-07-27T10:24:18Z

📌 Commit 9e299ab has been approved by pietroalbini

bors · 2021-07-27T10:34:57Z

⌛ Testing commit 9e299ab with merge 39ccc36d808a84a90c5e4c2eff05e2b2bb0325b3...

bors · 2021-07-27T10:38:36Z

💔 Test failed - checks-actions

emilyalbini · 2021-07-27T13:04:14Z

@bors retry

bors · 2021-07-27T13:24:29Z

⌛ Testing commit 9e299ab with merge bf96b3ec2f66884de2a9030063970bc1b869293b...

bors · 2021-07-27T13:31:35Z

💔 Test failed - checks-actions

fee1-dead · 2021-07-27T14:16:48Z

That spurious CI error looks exactly the same as this. See the comments on that PR for more info.

fee1-dead · 2021-07-28T01:59:05Z

Hmm, that seems like it resolved itself in that PR? Let's try again.

I don't think so, because the PR's CI keeps failing, but bors' tests pass. For this PR it's the reverse I guess. I think you should just open another PR and see if it will resolve.

This reverts commit d6962ff.

…nymore even if not emitted" This reverts commit 13bdc5c.

emilyalbini · 2021-07-28T07:20:16Z

Reverted #86623, which should be the cause of this issue.

@bors r+ p=1000 rollup=never

bors · 2021-07-28T07:20:17Z

📌 Commit 8ebc97f has been approved by pietroalbini

bors · 2021-07-28T08:53:58Z

⌛ Testing commit 8ebc97f with merge 374d9779c83f6d429ff2389767e6f64bf1e1fedd...

bors · 2021-07-28T09:01:01Z

💔 Test failed - checks-actions

emilyalbini · 2021-07-28T13:20:52Z

The x86_64-gnu-stable job can't work on beta. Added the last commit to only run that job on nightly. r? @Mark-Simulacrum

Mark-Simulacrum · 2021-07-28T13:23:45Z

@bors r+

Please make sure that commit lands on master as well. However, we might want to explore making a different fix, that lets us test the stable branch while having dev: 1 -- I'm worried about beta->stable promotion failing if we don't have that.

bors · 2021-07-28T13:23:46Z

📌 Commit 87d2c59 has been approved by Mark-Simulacrum

emilyalbini · 2021-07-28T13:33:48Z

Opened the backport PR in #87550.

bors · 2021-07-28T14:09:53Z

⌛ Testing commit 87d2c59 with merge 739f8f0...

bors · 2021-07-28T16:58:54Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 739f8f0 to beta...

…r=Mark-Simulacrum Add `CI_ONLY_WHEN_CHANNEL` and run `x86_64-gnu-stable` only on nightly Backporting a commit made on rust-lang#87508. cc `@Mark-Simulacrum`

…r=Mark-Simulacrum Add `CI_ONLY_WHEN_CHANNEL` and run `x86_64-gnu-stable` only on nightly Backporting a commit made on rust-lang#87508. cc ``@Mark-Simulacrum``

this is now 1.55 beta

56397e9

rust-highfive assigned Mark-Simulacrum Jul 27, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2021

XAMPPRocky and others added 2 commits July 27, 2021 12:21

backport release notes

b212f79

Rustdoc accessibility: use real headers for doc items

9e299ab

Part of rust-lang#87059 Partially reverts rust-lang#84703 Preview at: https://notriddle.com/notriddle-rustdoc-test/real-headers/std/index.html

emilyalbini mentioned this pull request Jul 27, 2021

Rustdoc accessibility: use real headers for doc items #87390

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2021

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2021

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2021

emilyalbini added 2 commits July 28, 2021 09:18

Revert "Only run error code explanation removal check if on CI"

2b2bf6c

This reverts commit d6962ff.

Revert "Add check to ensure error code explanations are not removed a…

8ebc97f

…nymore even if not emitted" This reverts commit 13bdc5c.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2021

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 28, 2021

This comment has been minimized.

Sign in to view

add CI_ONLY_WHEN_CHANNEL and run x86_64-gnu-stable only on nightly

87d2c59

emilyalbini force-pushed the beta-next branch from 3eaf5c4 to 87d2c59 Compare July 28, 2021 13:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2021

emilyalbini mentioned this pull request Jul 28, 2021

Add CI_ONLY_WHEN_CHANNEL and run x86_64-gnu-stable only on nightly #87550

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 28, 2021

bors merged commit 739f8f0 into rust-lang:beta Jul 28, 2021

rustbot added this to the 1.55.0 milestone Jul 28, 2021

Uh oh!

Conversation

emilyalbini commented Jul 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jul 27, 2021

Uh oh!

rust-highfive commented Jul 27, 2021

Uh oh!

emilyalbini commented Jul 27, 2021

Uh oh!

bors commented Jul 27, 2021

Uh oh!

emilyalbini commented Jul 27, 2021

Uh oh!

bors commented Jul 27, 2021

Uh oh!

bors commented Jul 27, 2021

Uh oh!

bors commented Jul 27, 2021

Uh oh!

This comment has been minimized.

emilyalbini commented Jul 27, 2021

Uh oh!

bors commented Jul 27, 2021

Uh oh!

This comment has been minimized.

bors commented Jul 27, 2021

Uh oh!

fee1-dead commented Jul 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fee1-dead commented Jul 28, 2021

Uh oh!

emilyalbini commented Jul 28, 2021

Uh oh!

bors commented Jul 28, 2021

Uh oh!

bors commented Jul 28, 2021

Uh oh!

This comment has been minimized.

bors commented Jul 28, 2021

Uh oh!

This comment has been minimized.

emilyalbini commented Jul 28, 2021

Uh oh!

Mark-Simulacrum commented Jul 28, 2021

Uh oh!

bors commented Jul 28, 2021

Uh oh!

emilyalbini commented Jul 28, 2021

Uh oh!

bors commented Jul 28, 2021

Uh oh!

bors commented Jul 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

emilyalbini commented Jul 27, 2021 •

edited

Loading

fee1-dead commented Jul 27, 2021 •

edited

Loading