os current_exe using same approach as linux to get always the full ab…#87631
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 5, 2021
devnexen:solarish_upd_fs
Merged
os current_exe using same approach as linux to get always the full ab…#87631bors merged 1 commit intorust-lang:masterfrom devnexen:solarish_upd_fs
bors merged 1 commit intorust-lang:masterfrom
devnexen:solarish_upd_fs
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
bjorn3
reviewed
Jul 31, 2021
library/std/src/sys/unix/os.rs
Outdated
Member
There was a problem hiding this comment.
Maybe still use getexecname if /proc is not mounted? I am guessing this could happen inside containers.
Member
|
The commit says "same approach as linux", but I am not seeing similar code elsewhere in this file. Regardless, this is not really my area of expertise so.. let's try r? @joshtriplett perhaps? |
Contributor
Author
|
originally it was closer but difference now there is fallback code path. |
…solute path but in case of failure (e.g. prcfs not mounted) still using getexecname.
camelid
added
S-waiting-on-review
inquisitivecrystal
added
T-libs
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
Member
|
I don't know Solaris, but the approach seems reasonable, and I see various references confirming that @bors r+ |
Collaborator
|
📌 Commit cb4519e has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 5, 2021
os current_exe using same approach as linux to get always the full ab… …solute path
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 5, 2021
…arth Rollup of 12 pull requests Successful merges: - rust-lang#87631 (os current_exe using same approach as linux to get always the full ab…) - rust-lang#88234 (rustdoc-json: Don't ignore impls for primitive types) - rust-lang#88651 (Use the 64b inner:monotonize() implementation not the 128b one for aarch64) - rust-lang#88816 (Rustdoc migrate to table so the gui can handle >2k constants) - rust-lang#89244 (refactor: VecDeques PairSlices fields to private) - rust-lang#89364 (rustdoc-json: Encode json files with UTF-8) - rust-lang#89423 (Fix ICE caused by non_exaustive_omitted_patterns struct lint) - rust-lang#89426 (bootstrap: add config option for nix patching) - rust-lang#89462 (haiku thread affinity build fix) - rust-lang#89482 (Follow the diagnostic output style guide) - rust-lang#89504 (Don't suggest replacing region with 'static in NLL) - rust-lang#89535 (fix busted JavaScript in error index generator) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…solute path