On macOS, make strip="symbols" not pass any options to strip#88137
On macOS, make strip="symbols" not pass any options to strip#88137bors merged 1 commit intorust-lang:masterfrom
Conversation
This makes the output with `strip="symbols"` match the result of just calling `strip` on the output binary, minimizing the size of the binary.
joshtriplett
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
I'm not an expert on macOS, but the changes look reasonable. CC @rust-lang/compiler
Marking as needing attention of the team next thursday.
|
Anyone available to review and r+ this? I'd love to get this merged, to unblock support for strip in cargo. |
|
During the compiler team triage meeting it was mentioned that we'd like @alexcrichton to take a look (because Alex knows about this kind of stuff on OSX). If there is no progress in a couple of days, I'll take a look. |
|
Ah sorry I don't know much about |
|
Thanks, @alexcrichton! I'll take a look then. @joshtriplett, what is the motivation behind this change? Why exactly is it needed to unblock strip in cargo? |
|
Stable support for strip in cargo needs stable support for strip in rustc, as well as reasonable support for common targets. Once we stabilize strip in rustc, it'll be much harder to change its behavior without risking compatibility issues. So I'd like to get this change in, then stabilize strip in rustc, then stabilize it in cargo. |
|
https://github.com/rust-lang/rust/pull/88137/files#r691191650 gives the explanation I was looking for. @bors r+ |
|
📌 Commit ff697c6 has been approved by |
bors
added
S-waiting-on-bors
…ption, r=michaelwoerister On macOS, make strip="symbols" not pass any options to strip This makes the output with `strip="symbols"` match the result of just calling `strip` on the output binary, minimizing the size of the binary.
…ption, r=michaelwoerister On macOS, make strip="symbols" not pass any options to strip This makes the output with `strip="symbols"` match the result of just calling `strip` on the output binary, minimizing the size of the binary.
…ingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#87918 (Enable AutoFDO.) - rust-lang#88137 (On macOS, make strip="symbols" not pass any options to strip) - rust-lang#88772 (Fixed confusing wording on Result::map_or_else.) - rust-lang#89025 (Implement `#[link_ordinal(n)]`) - rust-lang#89082 (Implement rust-lang#85440 (Random test ordering)) - rust-lang#89288 (Wrapper for `-Z gcc-ld=lld` to invoke rust-lld with the correct flavor) - rust-lang#89476 (Correct decoding of foreign expansions during incr. comp.) - rust-lang#89622 (Use correct edition for panic in [debug_]assert!().) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
11 participants
This makes the output with
strip="symbols"match the result of justcalling
stripon the output binary, minimizing the size of the binary.