Fix ICE when `start` lang item has wrong generics#88782

asquared31415 · 2021-09-09T15:23:05Z

In my previous pr #87875 I missed the requirements on the start lang item due to its relative difficulty to test and opting for more conservative estimates. This fixes that by updating the requirement to be exactly one generic type.

The start lang item should have exactly one generic type for the return type of the main fn ptr passed to it. I believe having zero would previously sometimes compile (often with the use of fn() -> () as the fn ptr but it was likely UB to call if the return type of main was not () as far as I know) however it also sometimes would not for various errors including ICEs and LLVM errors depending on exact situations. Having more than 1 generic has always failed with an ICE because only the one generic type is expected and provided.

Fixes #79559, fixes #73584, fixes #83117 (all duplicates)
Relevant to #9307

r? @cjgillot

asquared31415 · 2021-09-09T16:08:51Z

Not entirely sure of the purpose of that test, but simple enough to fix since it seems to be a stub

src/test/run-make-fulldeps/target-specs/foo.rs

cjgillot · 2021-09-14T04:01:16Z

@bors r+

bors · 2021-09-14T04:01:18Z

📌 Commit 8be3e26 has been approved by cjgillot

Fix ICE when `start` lang item has wrong generics In my previous pr rust-lang#87875 I missed the requirements on the `start` lang item due to its relative difficulty to test and opting for more conservative estimates. This fixes that by updating the requirement to be exactly one generic type. The `start` lang item should have exactly one generic type for the return type of the `main` fn ptr passed to it. I believe having zero would previously *sometimes* compile (often with the use of `fn() -> ()` as the fn ptr but it was likely UB to call if the return type of `main` was not `()` as far as I know) however it also sometimes would not for various errors including ICEs and LLVM errors depending on exact situations. Having more than 1 generic has always failed with an ICE because only the one generic type is expected and provided. Fixes rust-lang#79559, fixes rust-lang#73584, fixes rust-lang#83117 (all duplicates) Relevant to rust-lang#9307 r? ``@cjgillot``

Manishearth · 2021-09-14T18:57:40Z

@bors r-

failed #88939, minor test issue

-error: methods called `as_*` usually take `self` by reference or `self` by mutable reference
-  --> $DIR/def_id_nocore.rs:26:19
+error[E0718]: `start` language item must be applied to a function with 1 generic argument
    |
    |
-LL |     pub fn as_ref(self) -> &'static str {
-   |                   ^^^^
-   |
-   = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
-   = help: consider choosing a less ambiguous name
+LL | #[lang = "start"]
+   | ^^^^^^^^^^^^^^^^^
+LL | #[start]
+LL | fn start(_argc: isize, _argv: *const *const u8) -> isize {
+   |         - this function has 0 generic arguments
 error: aborting due to previous error

Manishearth · 2021-09-14T20:43:22Z

@bors r=cjgillot

bors · 2021-09-14T20:43:24Z

📌 Commit da909791b38daf238052f3824c67e9ba6a80df72 has been approved by cjgillot

cjgillot · 2021-09-26T10:06:22Z

@bors r+

bors · 2021-09-26T10:06:24Z

📌 Commit 05460d0 has been approved by cjgillot

bors · 2021-09-26T10:59:08Z

⌛ Testing commit 05460d0 with merge fe04f4636be12f73c7c82eee4b59dc12bcafd7a1...

asquared31415 · 2021-09-26T23:55:34Z

uhhhh no clue what that's about there doesn't seem to be any real failure? or a log?

cjgillot · 2021-09-29T17:18:40Z

@bors retry

bors · 2021-09-29T21:36:41Z

⌛ Testing commit 05460d0 with merge e1175211fec017f2564a213fc73c68302e5b91eb...

bors · 2021-09-29T21:42:15Z

💔 Test failed - checks-actions

ehuss · 2021-09-29T21:45:02Z

@bors retry
Issue with Windows LLDB

Fix ICE when `start` lang item has wrong generics In my previous pr rust-lang#87875 I missed the requirements on the `start` lang item due to its relative difficulty to test and opting for more conservative estimates. This fixes that by updating the requirement to be exactly one generic type. The `start` lang item should have exactly one generic type for the return type of the `main` fn ptr passed to it. I believe having zero would previously *sometimes* compile (often with the use of `fn() -> ()` as the fn ptr but it was likely UB to call if the return type of `main` was not `()` as far as I know) however it also sometimes would not for various errors including ICEs and LLVM errors depending on exact situations. Having more than 1 generic has always failed with an ICE because only the one generic type is expected and provided. Fixes rust-lang#79559, fixes rust-lang#73584, fixes rust-lang#83117 (all duplicates) Relevant to rust-lang#9307 r? `@cjgillot`

Fix ICE when `start` lang item has wrong generics In my previous pr rust-lang#87875 I missed the requirements on the `start` lang item due to its relative difficulty to test and opting for more conservative estimates. This fixes that by updating the requirement to be exactly one generic type. The `start` lang item should have exactly one generic type for the return type of the `main` fn ptr passed to it. I believe having zero would previously *sometimes* compile (often with the use of `fn() -> ()` as the fn ptr but it was likely UB to call if the return type of `main` was not `()` as far as I know) however it also sometimes would not for various errors including ICEs and LLVM errors depending on exact situations. Having more than 1 generic has always failed with an ICE because only the one generic type is expected and provided. Fixes rust-lang#79559, fixes rust-lang#73584, fixes rust-lang#83117 (all duplicates) Relevant to rust-lang#9307 r? ``@cjgillot``

Fix ICE when `start` lang item has wrong generics In my previous pr rust-lang#87875 I missed the requirements on the `start` lang item due to its relative difficulty to test and opting for more conservative estimates. This fixes that by updating the requirement to be exactly one generic type. The `start` lang item should have exactly one generic type for the return type of the `main` fn ptr passed to it. I believe having zero would previously *sometimes* compile (often with the use of `fn() -> ()` as the fn ptr but it was likely UB to call if the return type of `main` was not `()` as far as I know) however it also sometimes would not for various errors including ICEs and LLVM errors depending on exact situations. Having more than 1 generic has always failed with an ICE because only the one generic type is expected and provided. Fixes rust-lang#79559, fixes rust-lang#73584, fixes rust-lang#83117 (all duplicates) Relevant to rust-lang#9307 r? ```@cjgillot```

…arth Rollup of 8 pull requests Successful merges: - rust-lang#88782 (Fix ICE when `start` lang item has wrong generics) - rust-lang#89202 (Resolve infered types when complaining about unexpected call type ) - rust-lang#89248 (Suggest similarly named associated items in trait impls) - rust-lang#89303 (Add `#[must_not_suspend]` to some types in std) - rust-lang#89306 (thread: implements available_concurrency on haiku) - rust-lang#89314 (fix(lint): don't suggest refutable patterns to "fix" irrefutable bind) - rust-lang#89370 (CTFE: tweak aggregate rvalue handling) - rust-lang#89392 (bootstrap: Update comment in config.library.toml.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Fix ICE when `start` lang item has wrong generics In my previous pr rust-lang#87875 I missed the requirements on the `start` lang item due to its relative difficulty to test and opting for more conservative estimates. This fixes that by updating the requirement to be exactly one generic type. The `start` lang item should have exactly one generic type for the return type of the `main` fn ptr passed to it. I believe having zero would previously *sometimes* compile (often with the use of `fn() -> ()` as the fn ptr but it was likely UB to call if the return type of `main` was not `()` as far as I know) however it also sometimes would not for various errors including ICEs and LLVM errors depending on exact situations. Having more than 1 generic has always failed with an ICE because only the one generic type is expected and provided. Fixes rust-lang#79559, fixes rust-lang#73584, fixes rust-lang#83117 (all duplicates) Relevant to rust-lang#9307 r? ````@cjgillot````

rust-highfive assigned cjgillot Sep 9, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2021

asquared31415 force-pushed the issue-79559 branch from 4eea680 to 0184e4f Compare September 9, 2021 15:27

This comment has been minimized.

Sign in to view

asquared31415 force-pushed the issue-79559 branch from 0184e4f to 2052839 Compare September 9, 2021 16:09

bjorn3 reviewed Sep 10, 2021

View reviewed changes

src/test/run-make-fulldeps/target-specs/foo.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2021

Manishearth mentioned this pull request Sep 14, 2021

Rollup of 8 pull requests #88939

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 14, 2021

Fix ICE when start lang item has wrong generics

16c0a84

asquared31415 force-pushed the issue-79559 branch from 8be3e26 to da90979 Compare September 14, 2021 20:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2021

This comment has been minimized.

Sign in to view

asquared31415 force-pushed the issue-79559 branch from da90979 to 0dbcd8f Compare September 14, 2021 22:07

This comment has been minimized.

Sign in to view

update test

05460d0

asquared31415 force-pushed the issue-79559 branch from 0dbcd8f to 05460d0 Compare September 14, 2021 22:47

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2021

This comment has been minimized.

Sign in to view

ehuss mentioned this pull request Sep 30, 2021

Rollup of 8 pull requests #89399

Closed

Manishearth mentioned this pull request Sep 30, 2021

Rollup of 10 pull requests #89402

Closed

Manishearth mentioned this pull request Sep 30, 2021

Rollup of 9 pull requests #89411

Closed

Manishearth mentioned this pull request Oct 1, 2021

Rollup of 8 pull requests #89414

Merged

bors merged commit 3d86aac into rust-lang:master Oct 1, 2021

rustbot added this to the 1.57.0 milestone Oct 1, 2021

asquared31415 deleted the issue-79559 branch October 9, 2021 17:02

Uh oh!

Conversation

asquared31415 commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

asquared31415 commented Sep 9, 2021

Uh oh!

Uh oh!

cjgillot commented Sep 14, 2021

Uh oh!

bors commented Sep 14, 2021

Uh oh!

Manishearth commented Sep 14, 2021

Uh oh!

Manishearth commented Sep 14, 2021

Uh oh!

bors commented Sep 14, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

cjgillot commented Sep 26, 2021

Uh oh!

bors commented Sep 26, 2021

Uh oh!

bors commented Sep 26, 2021

Uh oh!

asquared31415 commented Sep 26, 2021

Uh oh!

cjgillot commented Sep 29, 2021

Uh oh!

bors commented Sep 29, 2021

Uh oh!

bors commented Sep 29, 2021

Uh oh!

ehuss commented Sep 29, 2021

Uh oh!

This comment has been minimized.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

asquared31415 commented Sep 9, 2021 •

edited

Loading