Skip to content

Disable validate_maintainers.#88977

Merged
bors merged 2 commits intorust-lang:masterfrom
ehuss:disable-validate-maintainers
Sep 16, 2021
Merged

Disable validate_maintainers.#88977
bors merged 2 commits intorust-lang:masterfrom
ehuss:disable-validate-maintainers

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 15, 2021

The validate_maintainers check has started to fail with the error:

HTTPError: HTTP Error 403: Forbidden
b'{"message":"Must have admin access to view repository collaborators.","documentation_url":"https://docs.github.com/rest/reference/repos#list-repository-collaborators"}'

Apparently GitHub has restricted the collaborators API to admins. For now, this just disables the check to get CI working again. Eventually, I think we'll just need to remove the check since we will unlikely use an admin token, and I don't see a workaround. The MAINTAINERS list doesn't change often, so we may just need to put a sternly worded comment near the list.

@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 15, 2021

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2021
@ehuss ehuss mentioned this pull request Sep 15, 2021
Merged
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Sep 15, 2021

@bors r+ p=101

I think most of the time the validation broke when users renamed themselves. Maybe the way to go is move the pinging/assignment out of the toolstate code and into e.g. triagebot, which has more options for who to yell at, and make it depend on rust-lang/team there (which validates users existence and fails CI).

@bors
Copy link
Collaborator

bors commented Sep 15, 2021

📌 Commit 6070763 has been approved by Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Sep 15, 2021

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@bors
Copy link
Collaborator

bors commented Sep 15, 2021

⌛ Testing commit 6070763 with merge a011a3ec4c6f3351c473f094871fe8bc40d57daa...

@bors
Copy link
Collaborator

bors commented Sep 15, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ehuss
Copy link
Contributor Author

ehuss commented Sep 15, 2021

@bors retry

Not really clear why it failed. No failed jobs, just a few listed as "cancelled".

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@bors
Copy link
Collaborator

bors commented Sep 15, 2021

⌛ Testing commit 6070763 with merge f2f9fe5bdafb84a9aebe13ae9741a2337737a132...

@bors
Copy link
Collaborator

bors commented Sep 15, 2021

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Sep 15, 2021

@bors retry

I have no idea why this is failing.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@bors
Copy link
Collaborator

bors commented Sep 15, 2021

⌛ Testing commit 6070763 with merge 0c593eb4ae08b7a1599f40f6809d1246cc0f7812...

@bors
Copy link
Collaborator

bors commented Sep 15, 2021

⌛ Testing commit 6070763 with merge b42c69271cb5c234317c7da35b31556450952f0a...

@ehuss
Copy link
Contributor Author

ehuss commented Sep 15, 2021

@Manishearth Oh, sorry, should have posted here, too. The error is legit, there was an image update this morning. I'm going to poke at it a bit.

@Manishearth
Copy link
Member

Manishearth commented Sep 15, 2021

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Sep 15, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 15, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Sep 15, 2021

GitHub updated the Windows image this morning with a new WDK which brings about a new debugger version (10.0.22000.1) which has caused one of the debuginfo tests to fail. I disabled it for now to get CI moving.

Image changes: actions/runner-images@adce9b6#diff-816219d3c9f30fcc1c40f88ca826c1662bf99eded781c1b419dd2dfb577ae227

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Sep 15, 2021

📌 Commit 66a1987 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@bors
Copy link
Collaborator

bors commented Sep 15, 2021

⌛ Testing commit 66a1987 with merge 4aed1ab...

@bors
Copy link
Collaborator

bors commented Sep 16, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 4aed1ab to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 16, 2021
@bors bors merged commit 4aed1ab into rust-lang:master Sep 16, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 16, 2021
@ehuss ehuss mentioned this pull request Sep 16, 2021
Merged
@ehuss ehuss added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 16, 2021
@ehuss ehuss mentioned this pull request Sep 16, 2021
Merged
@cuviper
Copy link
Member

cuviper commented Sep 16, 2021

Who needs to evaluate the beta nomination here? The issue is presumed to be blocking the current backports in #88946.

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Sep 16, 2021

beta-accepting unilaterally.

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 16, 2021
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 16, 2021
@cuviper cuviper modified the milestones: 1.57.0, 1.56.0 Sep 16, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2021
@bors
Auto merge of rust-lang#88946 - cuviper:beta-next, r=Mark-Simulacrum
deef866 
[beta] backports

- rustdoc: Fix ICE with `doc(hidden)` on tuple variant fields rust-lang#88639
- Fix 2021 `dyn` suggestion that used code as label rust-lang#88657
- Workaround blink/chromium grid layout limitation of 1000 rows rust-lang#88776
- Change scope of temporaries in match guards rust-lang#88678
- Add a regression test for rust-lang#88649 rust-lang#88691
- Revert anon union parsing rust-lang#88775
- Disable validate_maintainers. rust-lang#88977

Also drop stage0 rustfmt, because that's only supposed to be used on master.

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

8 participants

@ehuss @rust-highfive @Mark-Simulacrum @bors @rust-log-analyzer @Manishearth @cuviper @rustbot