feat(rustc_parse): recover from pre-RFC-2000 const generics syntax#89029
Merged
bors merged 4 commits intorust-lang:masterfrom Oct 1, 2021
Merged
feat(rustc_parse): recover from pre-RFC-2000 const generics syntax#89029bors merged 4 commits intorust-lang:masterfrom
bors merged 4 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
I don't know this code at all, so this may take me a bit of time. |
estebank
reviewed
Sep 28, 2021
Contributor
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
The changes look reasonable, left a few nitpicks.
src/test/ui/const-generics/parser-error-recovery/issue-89013-type.stderr
Outdated
Show resolved
Hide resolved
src/test/ui/const-generics/parser-error-recovery/issue-89013.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
Co-authored-by: Esteban Kuber <esteban@kuber.com.ar>
… there's other problems As shown in the two test requirements that got updated, if there's other problems, then those other problems are probably the root cause of the incorrect generics count.
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 105b60f has been approved by |
bors
added
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Oct 1, 2021
…estebank feat(rustc_parse): recover from pre-RFC-2000 const generics syntax Fixes rust-lang#89013
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 1, 2021
…arth Rollup of 6 pull requests Successful merges: - rust-lang#87868 (Added -Z randomize-layout flag) - rust-lang#88820 (Add `pie` as another `relocation-model` value) - rust-lang#89029 (feat(rustc_parse): recover from pre-RFC-2000 const generics syntax) - rust-lang#89322 (Reapply "Remove optimization_fuel_crate from Session") - rust-lang#89340 (Improve error message for `printf`-style format strings) - rust-lang#89415 (Correct caller/callsite confusion in inliner message) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89013