Change the order of imports suggestions#89224
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 26, 2021
Merged
Conversation
Member
|
@bors r+ |
Collaborator
|
📌 Commit 4c23905 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2021
…arth Rollup of 7 pull requests Successful merges: - rust-lang#88895 (rustdoc: Cleanup `clean` part 2) - rust-lang#88973 (Expose the std_detect env_override feature) - rust-lang#89010 (Add some intra doc links) - rust-lang#89198 (rustdoc: Don't show hidden trait methods) - rust-lang#89216 (Consistent big O notation) - rust-lang#89224 (Change the order of imports suggestions) - rust-lang#89256 (Fix typo in release notes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Member
|
Does this change need a regression test for the diagnostic? |
|
I am not sure, but it seems this has stopped working. On this code: fn main() {
let _ = Wrapping(5_u32);
}rustc gives now (rustc 1.58.0-nightly 29b1248 2021-10-25): error[E0425]: cannot find function, tuple struct or tuple variant `Wrapping` in this scope
--> ...\test.rs:2:13
|
2 | let _ = Wrapping(5_u32);
| ^^^^^^^^ not found in this scope
|
help: consider importing one of these items
|
1 | use core::num::Wrapping;
|
1 | use std::num::Wrapping;
| |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #83564