Conversation
self_named_constructor -> self_named_constructors append_instead_of_extend -> extend_with_drain
[beta] Backport: Rename two lints to comply with our lint naming convention self_named_constructor -> self_named_constructors append_instead_of_extend -> extend_with_drain changelog: none r? `@ghost`
Adapts clippy for fe1a7f7
Update Clippy r? `@Manishearth`
Allow giving reasons for `disallowed_methods` Fixes rust-lang#7609. This permits writing the config for `disallowed-methods` as either a list of strings (like before) or a list of tables, where each table gives the path to the disallowed method and an optional reason for why the method is disallowed. changelog: Allow giving reasons for [`disallowed_methods`]
Add new lint `iter_not_returning_iterator` Add new lint [`iter_not_returning_iterator`] to detect method `iter()` or `iter_mut()` returning a type not implementing `Iterator` changelog: Add new lint [`iter_not_returning_iterator`]
Backport remerge This is to keep the backported commit in the repository before force pushing the new beta branch. r? `@ghost` changelog: none (literally none)
Fix derivable impl false positives fix rust-lang#7654 fix rust-lang#7655 changelog: none (not released)
Contributor
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
Collaborator
Member
|
@bors r+ p=1 we've got some CI flakiness in GHA but let's see how this goes |
Collaborator
|
📌 Commit d0fb9db has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
Reopen the PR? |
Member
|
eh, we can just wait for bors to run full tests. |
Collaborator
|
⌛ Testing commit d0fb9db with merge c082958a881380b02c2f322e66cbdd10d7435f0b... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
Member
Author
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Sep 29, 2021
Collaborator
|
Finished benchmarking commit (6f608ce): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delayed Clippy sync
r? @Manishearth