Improve wording of map_or_else docs#89400
Conversation
Changes doc text to refer to the "default" parameter as the "default" function.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Thanks! Indeed this was written in a very confusing way before.
|
@bors r+ rollup |
|
📌 Commit 35b0015 has been approved by |
bors
added
S-waiting-on-bors
…x, r=dtolnay Improve wording of `map_or_else` docs Changes doc text to refer to the "default" parameter as the "default" function. Previously, the doc text referred to the "f" parameter as the "default" function; and the "default" parameter as the "fallback" function.
…x, r=dtolnay Improve wording of `map_or_else` docs Changes doc text to refer to the "default" parameter as the "default" function. Previously, the doc text referred to the "f" parameter as the "default" function; and the "default" parameter as the "fallback" function.
…ingjubilee Rollup of 13 pull requests Successful merges: - rust-lang#83655 ([aarch64] add target feature outline-atomics) - rust-lang#87091 (implement advance_(back_)_by on more iterators) - rust-lang#88451 (Fix an ICE caused by type mismatch errors being ignored) - rust-lang#88452 (VecDeque: improve performance for From<[T; N]>) - rust-lang#89400 (Improve wording of `map_or_else` docs) - rust-lang#89407 (Recommend running `cargo clean` in E0514 output) - rust-lang#89443 (Include the length in BTree hashes) - rust-lang#89444 (rustdoc: use slice::contains instead of open-coding it) - rust-lang#89447 (Improve error message for missing angle brackets in `[_]::method`) - rust-lang#89453 (Consistently use 'supertrait'.) - rust-lang#89483 (Practice diagnostic message convention) - rust-lang#89500 (Fix ICE with buffered lint referring to AST node deleted by everybody_loops) - rust-lang#89508 (Stabilize `const_panic`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
I'm sorry but I feel a bit robbed? I made a pull request a month ago #88772 =/ |
|
Geez, sincere apologies on that. I clearly didn't look around much before making this; I should have searched through open PRs and issues. I was tunnel visioned on the contributing docs as I had not contributed to this project before. This entire PR was made the morning after a rough experience last Wednesday from a doc misunderstanding. |
I'm sorry about that. We split up our reviews across the team and different members have different availability. The end result is most of us are only aware of a subset of active PRs and those PRs get reviewed in fairly random order, so I assure you it wasn't intentional 😅 . If you want to update your PR to add the additional context ontop of this one I'd be happy to review and merge your additions as well. |
7 participants
Changes doc text to refer to the "default" parameter as the "default"
function.
Previously, the doc text referred to the "f" parameter as the "default" function; and the "default" parameter as the "fallback" function.