add type name to tydesc + minor repr improvement#8947
Closed
thestinger wants to merge 2 commits intorust-lang:masterfrom
thestinger:name
Closed
add type name to tydesc + minor repr improvement#8947thestinger wants to merge 2 commits intorust-lang:masterfrom thestinger:name
thestinger wants to merge 2 commits intorust-lang:masterfrom
thestinger:name
Conversation
bors
added a commit
that referenced
this pull request
Sep 3, 2013
Storing the type name in the `tydesc` aims to avoid the need to pass a type name in almost every single visitor method. It would likely be much saner for `repr` to simply be passed the `TyDesc` corresponding to the function or just the type name, but this is good enough for now.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 16, 2022
…ednet Add lint output to lint list changelog: Add the ability to show the lint output in the lint list This just adds the logic to produce the output, it hasn't been added to any lints yet. It did help find some mistakes in some docs though 😄. ### Screenshots <details> <summary>A single code block</summary>  </details> <details> <summary>A single code block with a "Use instead" section</summary>  </details> <details> <summary>Multiple code blocks</summary>  </details> This is the last task in rust-lang#7172 🎉. r? `@xFrednet` (?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing the type name in the
tydescaims to avoid the need to pass a type name in almost every single visitor method.It would likely be much saner for
reprto simply be passed theTyDesccorresponding to the function or just the type name, but this is good enough for now.