Add #[must_use] to stdin/stdout/stderr locks#89693

jkugelman · 2021-10-09T04:00:27Z

Affected methods:

std::io           fn stdin_locked() -> StdinLock<'static>;
std::io::Stdin    fn lock(&self) -> StdinLock<'_>;
std::io::Stdin    fn into_locked(self) -> StdinLock<'static>;
std::io           fn stdout_locked() -> StdoutLock<'static>;
std::io::Stdout   fn lock(&self) -> StdoutLock<'_>;
std::io::Stdout   fn into_locked(self) -> StdoutLock<'static>;
std::io           fn stderr_locked() -> StderrLock<'static>;
std::io::Stderr   fn lock(&self) -> StderrLock<'_>;
std::io::Stderr   fn into_locked(self) -> StderrLock<'static>;

Parent issue: #89692

rust-highfive · 2021-10-09T04:00:30Z

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

joshtriplett · 2021-10-09T06:09:30Z

@bors r+

bors · 2021-10-09T06:09:32Z

📌 Commit e27bfb6 has been approved by joshtriplett

…err-locks, r=joshtriplett Add #[must_use] to stdin/stdout/stderr locks Affected methods: ```rust std::io fn stdin_locked() -> StdinLock<'static>; std::io::Stdin fn lock(&self) -> StdinLock<'_>; std::io fn stdout_locked() -> StdoutLock<'static>; std::io::Stdout fn lock(&self) -> StdoutLock<'_>; std::io fn stderr_locked() -> StderrLock<'static>; std::io::Stderr fn lock(&self) -> StderrLock<'_>; ``` Parent issue: rust-lang#89692

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88707 (String.split_terminator: Add an example when using a slice of chars) - rust-lang#89605 (Fix stabilization version for `bindings_after_at`) - rust-lang#89634 (rustc_driver: Enable the `WARN` log level by default) - rust-lang#89641 (make #[target_feature] work with `asm` register classes) - rust-lang#89678 (Fix minor std::thread documentation typo) - rust-lang#89684 (Fix asm docs typo) - rust-lang#89687 (Move `read2_abbreviated` function into read2.rs) - rust-lang#89693 (Add #[must_use] to stdin/stdout/stderr locks) - rust-lang#89694 (Add #[must_use] to string/char transformation methods) - rust-lang#89697 (Fix min LLVM version for bpf-types test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Add #[must_use] to stdin/stdout/stderr locks

e27bfb6

rust-highfive assigned dtolnay Oct 9, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2021

jkugelman mentioned this pull request Oct 9, 2021

Tracking issue for adding #[must_use] annotations throughout the standard library #89692

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021

joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 9, 2021

matthiaskrgr mentioned this pull request Oct 9, 2021

Rollup of 8 pull requests #89696

Closed

matthiaskrgr mentioned this pull request Oct 9, 2021

Rollup of 10 pull requests #89698

Merged

bors merged commit ee80459 into rust-lang:master Oct 9, 2021

rustbot added this to the 1.57.0 milestone Oct 9, 2021

jkugelman deleted the must-use-stdin-stdout-stderr-locks branch October 9, 2021 14:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add #[must_use] to stdin/stdout/stderr locks#89693