Merged
Conversation
We translate `i686` to `x86` which means tests marked as `only-i686` never ran. Update those tests to use `only-x86`.
…dtolnay Reorder `widening_impl`s to make the doc clearer Fixes rust-lang#88736 This moves `{widening,carrying}_mul`s to the bottom to place consts on the top.
…Mark-Simulacrum Fix tests using `only-i686` to use the correct `only-x86` directive We translate `i686` to `x86` which means tests marked as `only-i686` never ran. Update those tests to use `only-x86`. We parse the `only-` architecture directive here https://github.com/rust-lang/rust/blob/27143a9094b55a00d5f440b05b0cb4233b300d33/src/tools/compiletest/src/util.rs#L160-L168 and we translate `i686` to `x86` here https://github.com/rust-lang/rust/blob/27143a9094b55a00d5f440b05b0cb4233b300d33/src/tools/compiletest/src/util.rs#L56
…iser Warn for variables that are no longer captured r? `@wesleywiser` cc `@rust-lang/wg-rfc-2229` Fixes rust-lang#90465
Remove more checks for LLVM < 12 We already updated the minimum to 12 in rust-lang#90175, but we missed a few `get_version()` checks.
…n514 Properly register text_direction_codepoint_in_comment lint. This makes it known to the compiler so it can be configured like with `#![allow(text_direction_codepoint_in_comment)]`. Fixes rust-lang#90614.
Member
Author
|
@bors r+ p=5 rollup=never |
Collaborator
|
📌 Commit f5f6f73 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Nov 6, 2021
Collaborator
|
Finished benchmarking commit (d32993a): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
widening_impls to make the doc clearer #89942 (Reorderwidening_impls to make the doc clearer)only-i686to use the correctonly-x86directive #90569 (Fix tests usingonly-i686to use the correctonly-x86directive)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup