Merged
Conversation
This involves changing the lint to check the access level is exported, rather than public. The exported access level accounts for public items and items accessible to other crates with the help of `pub use` re-exports. The pattern of re-exporting public items from a private module is usage seen in a number of popular crates.
- Ensure standard public items are accepted - Ensure public items not re-exported from private modules are denied
This slightly reduces the noisiness of doc pages, making them easier to read.
Make Run button visible on hover This slightly reduces the noisiness of doc pages, making them easier to read. Demo: https://rustdoc.crud.net/jsha/run-on-hover/std/string/struct.String.html [Discussed on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/.22Run.22.20button.20visible.20on.20hover). Part of rust-lang#59845
Fix a pair of mistyped test cases in `std::net::ip` These two test cases are not consistent with their comments, which I believe is unintended.
…s, r=GuillaumeGomez Fix rustdoc::private_doc_tests lint for public re-exported items Closes rust-lang#72081 This involves changing the lint to check the access level is exported, rather than public. The [exported access level](https://github.com/rust-lang/rust/blob/e91ad5fc62bdee4a29c18baa5fad2ca42fc91bf4/compiler/rustc_middle/src/middle/privacy.rs#L24) accounts for public items and items accessible to other crates with the help of `pub use` re-exports. The pattern of re-exporting public items from a private module is usage seen in a number of popular crates.
…dtwco Some cleanups around check_argument_types Split out in ways from my rebase/continuation of rust-lang#71827 Commits are mostly self-explanatory and these changes should be fairly straightforward
…crum Regression test for borrowck ICE rust-lang#92015 This issue has come up a few times. Creating a regression test. Closes rust-lang#92015.
Fix font size for [src] links in headers Fixes rust-lang#90384. cc `@jsha` r? `@camelid`
…imitive-types, r=Manishearth Rustdoc: resolve associated traits for non-generic primitive types Fixes rust-lang#90703 This seems to work: <img width="457" alt="image" src="https://user-images.githubusercontent.com/2807772/147774059-9556ff96-4519-409e-8ed0-c33ecc436171.png"> I'm just afraid I might have missed some cases / broken previous functionality. I also have not written tests yet, I will have to take a look to see where tests are and how they are structured, but any help there is also appreciated.
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
|
📌 Commit 26a90e4 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 26a90e4 with merge 84121ce7f685b6ca2677282716d0224c7a24b4c9... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
Member
Author
|
@bors retry curl: (6) Could not resolve host: ci-mirrors.rust-lang.org |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Jan 6, 2022
Collaborator
|
Finished benchmarking commit (cfa4ac6): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
std::net::ip#92288 (Fix a pair of mistyped test cases instd::net::ip)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup