Merged
Conversation
If the target we're generating code for is msvc, then we do two main things differently: we generate type names in a C++ style instead of a Rust style and we generate debuginfo for enums differently. I've refactored the code so that there is one function (`cpp_like_debuginfo`) which determines if we should use the C++ style of naming types and other debuginfo generation or the regular Rust one.
Previously suggested in rust-lang/rfcs#2854. It makes sense to have this since `char` implements `From<u8>`. Likewise `u32`, `u64`, and `u128` (since rust-lang#79502) implement `From<char>`.
Implement `TryFrom<char>` for `u8` Previously suggested in rust-lang/rfcs#2854. It makes sense to have this since `char` implements `From<u8>`. Likewise `u32`, `u64`, and `u128` (since rust-lang#79502) implement `From<char>`.
…erister Remove &self from PrintState::to_string The point of `PrintState::to_string` is to create a `State` and evaluate the caller's closure on it: https://github.com/rust-lang/rust/blob/e9fbe79292783972a222afd270db3f77c0b4f3c8/compiler/rustc_ast_pretty/src/pprust/state.rs#L868-L872 Making the caller *also* construct and pass in a `State`, which is then ignored, was confusing.
…svc_check, r=michaelwoerister Consolidate checking for msvc when generating debuginfo If the target we're generating code for is msvc, then we do two main things differently: we generate type names in a C++ style instead of a Rust style and we generate debuginfo for enums differently. I've refactored the code so that there is one function (`cpp_like_debuginfo`) which determines if we should use the C++ style of naming types and other debuginfo generation or the regular Rust one. r? ``@michaelwoerister`` This PR is not urgent so please don't let it interrupt your holidays! 🎄 🎁
…ant-count, r=the8472 Add note about non_exhaustive to variant_count Since `variant_count` isn't returning something opaque, I thought it makes sense to explicitly call out that its return value may change for some enums. cc rust-lang#73662
…htriplett
Add some missing `#[must_use]` to some `f{32,64}` operations
This PR adds `#[must_use]` to the following methods:
- `f32::recip`
- `f32::max`
- `f32::min`
- `f32::maximum`
- `f32::minimum`
and their equivalents in `f64`.
These methods all produce a new value without modifying the original and so are pointless to call without using the result.
…-inline-style, r=jsha Create CSS class instead of using inline style for search results I saw this change in the update you proposed in rust-lang#92404. :) r? ``@jsha``
…allelism, r=joshtriplett Implement stabilization of `#[feature(available_parallelism)]` Stabilized in rust-lang#74479 (comment). Closes rust-lang#74479. Thanks! cc/ ``@rust-lang/libs-api``
Fix typo in `StableCrateId` docs
rustbot
added
T-compiler
Contributor
Author
|
@bors r+ rollup=never p=8 |
Collaborator
|
📌 Commit 05cfc4f has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 05cfc4f with merge 3421bde2b7b2cff5a1f047d7dc5bce6a8d844f1e... |
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
Author
|
@bors retry dist-x86_64-apple-alt failed with no logs |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Jan 8, 2022
Collaborator
|
Finished benchmarking commit (84abaf3): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
TryFrom<char>foru8#84640 (ImplementTryFrom<char>foru8)#[must_use]to somef{32,64}operations #92600 (Add some missing#[must_use]to somef{32,64}operations)#[feature(available_parallelism)]#92632 (Implement stabilization of#[feature(available_parallelism)])StableCrateIddocs #92650 (Fix typo inStableCrateIddocs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup