Fix try wrapping expression in variant suggestion with struct field shorthand#92808
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 17, 2022
Merged
Conversation
compiler-errors
commented
Jan 12, 2022
camelid
reviewed
Jan 13, 2022
469ed0b to
5dfaf5f
Compare
Contributor
Author
|
r? @camelid I fixed those places you asked for, and did some drive-by fixes as well. |
Member
|
The error output looks really nice, but unfortunately I don't think I have time to review the rest of this PR :) r? @davidtwco |
This comment has been minimized.
This comment has been minimized.
5dfaf5f to
272fb23
Compare
davidtwco
approved these changes
Jan 16, 2022
Member
davidtwco
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing, this looks great.
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 272fb23 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 17, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#92795 (Link sidebar "location" heading to top of page) - rust-lang#92799 (Remove some unnecessary uses of `FieldDef::ident`) - rust-lang#92808 (Fix `try wrapping expression in variant` suggestion with struct field shorthand) - rust-lang#92819 (rustdoc: remove hand-rolled isatty) - rust-lang#92876 (Fix suggesting turbofish with lifetime arguments) - rust-lang#92921 (Rename Printer constructor from mk_printer() to Printer::new()) - rust-lang#92937 (rustdoc: Add missing dot separator) - rust-lang#92953 (Copy an example to PartialOrd as well) - rust-lang#92977 (Docs: recommend VecDeque instead of Vec::remove(0)) - rust-lang#92981 (fix const_ptr_offset_from tracking issue) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a broken suggestion: playground
before:
after:
r? @m-ou-se
since you touched the code last in #91080