rustdoc settings: use radio buttons for theme#93251
Conversation
rustbot
added
the
T-rustdoc
This comment has been minimized.
This comment has been minimized.
This reduces the number of clicks required to change theme. Also, simplify the UI a bit (remove setting grouping), and add a "Back" link close to the settings icon.
|
It looks super nice! I have now two remarks/questions:
|
|
On desktop, it's nice to have the theme buttons aligned to the right side of the page (like the dropdowns currently are), so it's a short trip from the settings icon to the theme buttons. Also, I wanted to make sure to have I tried to reproduce the screenshot you showed, and the wrapping doesn't show up until the screen is narrower than 317px. I think that's such a rare screen size that it's okay if the buttons wrap. |
|
I find it hard on desktop to see that it's from the setting "themes" actually since there is no visual "helper". |
|
After a discussion, we decided to first land this change and to make a bigger refactoring on the settings menu overall. |
|
@bors: r+ rollup |
|
📌 Commit 11b17c6 has been approved by |
bors
added
the
S-waiting-on-bors
rustdoc settings: use radio buttons for theme This reduces the number of clicks required to change theme. Also, simplify the UI a bit (remove setting grouping), and add a "Back" link close to the settings icon. Demo: https://rustdoc.crud.net/jsha/theme-radio/settings.html r? `@GuillaumeGomez` New:  Old: 
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#88794 (Add a `try_clone()` function to `OwnedFd`.) - rust-lang#93064 (Properly track `DepNode`s in trait evaluation provisional cache) - rust-lang#93118 (Move param count error emission to end of `check_argument_types`) - rust-lang#93144 (Work around missing code coverage data causing llvm-cov failures) - rust-lang#93169 (Fix inconsistency of local blanket impls) - rust-lang#93175 (Implement stable overlap check considering negative traits) - rust-lang#93251 (rustdoc settings: use radio buttons for theme) - rust-lang#93269 (Use error-on-mismatch policy for PAuth module flags.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
I think this PR broke the display of the search bar: beta:
nightly:
Notice how the padding and border-radius are wrong. |
|
Ah, perhaps. The old and new screenshots in this PR's description show a change in the search box size, which misled me. |
|
Ah true. Well, it was a change done on purpose in any case. ;) |
6 participants
This reduces the number of clicks required to change theme.
Also, simplify the UI a bit (remove setting grouping), and add a "Back" link close to the settings icon.
Demo: https://rustdoc.crud.net/jsha/theme-radio/settings.html
r? @GuillaumeGomez
New:
Old: