debuginfo: Fix bug in type name generation for dyn types with associated types but no other generic arguments.#94810
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 15, 2022
Conversation
…ted types but no other generic arguments.
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
wesleywiser
approved these changes
Mar 15, 2022
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 5cd8a2a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 15, 2022
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#94810 (debuginfo: Fix bug in type name generation for dyn types with associated types but no other generic arguments.) - rust-lang#94947 (fix typos) - rust-lang#94956 (Fix small typo in FIXME) - rust-lang#94958 (Support other types of pluralization in pluralize macro) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For types like
&dyn Future<Output=bool>the compiler currently emits invalid types names in debuginfo. This PR fixes this.Before:
After:
These syntactically incorrect type names can cause downstream tools (e.g. debugger extensions) crash when trying to parse them.
r? @wesleywiser