Conversation
Contributor
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dtolnay
added
the
T-libs-api
dtolnay
approved these changes
Mar 18, 2022
Member
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
👍 this looks good. Please make a tracking issue.
3 tasks
Contributor
Author
|
Tracking issue: #95091 |
Member
|
@bors r+ |
Collaborator
|
📌 Commit a358ad2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#93858 (Add a `process_group` method to UNIX `CommandExt`) - rust-lang#94650 (Relax tests for Windows dos device names) - rust-lang#94991 (Make Weak::new const) - rust-lang#95072 (Re-enable parallel debuginfo tests) - rust-lang#95109 (Extend --check-cfg tests to all predicate inside all/any) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple enough. This is const creation of an allocating container, but no actual allocation is done, because it's defined to.