Skip to content

update CPU usage script#95446

Merged
bors merged 1 commit intorust-lang:masterfrom
seanpray:master
Jun 22, 2022
Merged

update CPU usage script#95446
bors merged 1 commit intorust-lang:masterfrom
seanpray:master

Conversation

@seanpray
Copy link
Contributor

@seanpray seanpray commented Mar 29, 2022

I've made slight changes to the CPU usage plot script with updated links from the ci2 aws instance.

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 29, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Mark-Simulacrum
Mark-Simulacrum reviewed Apr 6, 2022
View reviewed changes
src/etc/cpu-usage-over-time-plot.sh Outdated
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably shouldn't be changing to -alt, those are less typically queried than regular builders.

src/etc/cpu-usage-over-time-plot.sh Outdated
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A non-alt builder name is probably better here.

src/etc/cpu-usage-over-time-plot.sh Outdated
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a change that made these files cpu-dist-$name? I believe this script did work with just cpu-$builder, so I'm a little confused.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2022
@JohnCSimon
Copy link
Member

JohnCSimon commented May 7, 2022

Ping from triage:
@notseanray - can you please address the comments from .Mark-Simulacrum and fix the broken build? thank you

@seanpray
Copy link
Contributor Author

seanpray commented May 8, 2022

I made incorrect assumptions about cpu-$name being changed to cpu-dist-$name and -alt. I apologize as I did a poor job of checking things, sorry for any wasted time.

@apiraino apiraino added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label May 23, 2022
@JohnCSimon
Copy link
Member

JohnCSimon commented Jun 19, 2022 •
edited
Loading

triage: looks like this was ready for review but wasn't placed in review state.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 19, 2022
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 19, 2022

r=me with commits squashed into one

@JohnCSimon
Copy link
Member

JohnCSimon commented Jun 19, 2022 •
edited
Loading

my mistake
@rustbot author

@notseanray can you please squash the commits and then change to Waitingo-on-review with @rustbot ready ?
thank you

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2022
@seanpray
update cpu-usage-over-time-plot script
8eb7ddf 
fix tidy checks and correct cpu-usage-over-time-plot script
@seanpray
Copy link
Contributor Author

seanpray commented Jun 21, 2022

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2022
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 22, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 22, 2022

📌 Commit 8eb7ddf has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 22, 2022
@JohnTitor
Rollup merge of rust-lang#95446 - notseanray:master, r=Mark-Simulacrum
ecda292 
update CPU usage script

I've made slight changes to the CPU usage plot script with updated links from the [ci2 aws instance](https://rust-lang-ci2.s3.amazonaws.com/).
@JohnTitor JohnTitor mentioned this pull request Jun 22, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request Jun 22, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2022
@bors
Auto merge of rust-lang#98375 - JohnTitor:rollup-e5c6rgo, r=JohnTitor
89a0783 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#95446 (update CPU usage script)
 - rust-lang#96768 (Use futex based thread parker on Fuchsia.)
 - rust-lang#97454 (Add release notes for 1.62)
 - rust-lang#97516 (clarify how Rust atomics correspond to C++ atomics)
 - rust-lang#97818 (Point at return expression for RPIT-related error)
 - rust-lang#97895 (Simplify `likely!` and `unlikely!` macro)
 - rust-lang#98005 (Add some tests for impossible bounds)
 - rust-lang#98226 (Document unstable `--extern` options)
 - rust-lang#98356 (Add missing period)
 - rust-lang#98363 (remove use of &Alloc in btree tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7b442f7 into rust-lang:master Jun 22, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

8 participants

@seanpray @rust-highfive @rust-log-analyzer @JohnCSimon @Mark-Simulacrum @bors @apiraino @rustbot