Omit unnecessary help to add #[cfg(test)] when already annotated#96651
Merged
bors merged 1 commit intorust-lang:masterfrom May 18, 2022
ken-matsui:omit-unnecessary-help-to-add-cfg-test
Merged
Omit unnecessary help to add #[cfg(test)] when already annotated#96651bors merged 1 commit intorust-lang:masterfrom ken-matsui:omit-unnecessary-help-to-add-cfg-test
#[cfg(test)] when already annotated#96651bors merged 1 commit intorust-lang:masterfrom
ken-matsui:omit-unnecessary-help-to-add-cfg-test
Conversation
rustbot
added
the
T-compiler
Contributor
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
cjgillot
requested changes
May 7, 2022
Contributor
cjgillot
left a comment
cjgillot
left a comment
There was a problem hiding this comment.
Thanks for the PR @ken-matsui.
I believe that we can have a more robust implementation of this if we do not rely on the source_map, but rather on semantic information in the AST.
cjgillot
added
S-waiting-on-author
Contributor
Author
|
@cjgillot |
cjgillot
reviewed
May 14, 2022
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 03007de has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#96647 (rustdoc-json: Fix HRTBs for WherePredicate::BoundPredicate) - rust-lang#96651 (Omit unnecessary help to add `#[cfg(test)]` when already annotated) - rust-lang#96761 (rustdoc: don't build `rayon` for non-windows targets) - rust-lang#97096 (Types with reachable constructors are reachable) - rust-lang#97097 (Add tmm_reg clobbers) - rust-lang#97113 (Search GUI fixes) - rust-lang#97116 (interpret/validity: reject references to uninhabited types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #96611
The related PR is: #91770