Skip to content

Windows: No panic if function not (yet) available#97844

Merged
bors merged 1 commit intorust-lang:masterfrom
ChrisDenton:dont-panic
Jun 17, 2022
Merged

Windows: No panic if function not (yet) available#97844
bors merged 1 commit intorust-lang:masterfrom
ChrisDenton:dont-panic

Conversation

@ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Jun 7, 2022

In some situations (e.g. #97814) it is possible for required functions to be called before they've had a chance to be loaded. Therefore, we make it possible to recover from this situation simply by looking at error codes.

@rustbot label +O-windows

@ChrisDenton
Windows: No panic if function not (yet) available
34fafd3 
In some situations it is possible for required functions to be called before they've had a chance to be loaded. Therefore, we make it possible to recover from this situation simply by looking at error codes.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 7, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 7, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the O-windows Operating system: Windows label Jun 7, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 7, 2022

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2022
@JohnTitor
Copy link
Member

JohnTitor commented Jun 16, 2022

The change makes sense to me, confirmed that STATUS_NOT_IMPLEMENTED matches the value on https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-erref/596a1078-e883-4972-9bbc-49e60bebca55. And looking at https://docs.microsoft.com/en-us/windows/win32/api/winternl/nf-winternl-rtlntstatustodoserror, the implementation of RtlNtStatusToDosError seems correct.

About KeyedEvent-related fns, these are special cases, right? I couldn't find any official docs but a related PR, #77618. It'd be great if you could elaborate a bit about it, as I'm not an expert on it.

@ChrisDenton
Copy link
Member Author

ChrisDenton commented Jun 17, 2022

About KeyedEvent-related fns, these are special cases, right? I couldn't find any official docs but a related PR, #77618. It'd be great if you could elaborate a bit about it, as I'm not an expert on it.

The KeyedEvent functions are a fallback for Windows 7 which does not have WaitOnAddress or WakeByAddressSingle. They are indeed undocumented. The difference here is that we depend on NtCreateFile, NtReadFile and NtWriteFile always being available (for security or soundness reasons). Whereas the NtKeyedEvent* functions are fallbacks, so this PR doesn't touch them.

@JohnTitor
Copy link
Member

JohnTitor commented Jun 17, 2022

Makes sense, thanks for clarifying!
r? @JohnTitor @bors r+

@bors
Copy link
Collaborator

bors commented Jun 17, 2022

📌 Commit 34fafd3 has been approved by JohnTitor

@rust-highfive rust-highfive assigned JohnTitor and unassigned kennytm Jun 17, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2022
@bors
Auto merge of rust-lang#98193 - Dylan-DPC:rollup-5gihjij, r=Dylan-DPC
949a64a 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95392 (std: Stabilize feature try_reserve_2 )
 - rust-lang#97798 (Hide irrelevant lines in suggestions to allow for suggestions that are far from each other to be shown)
 - rust-lang#97844 (Windows: No panic if function not (yet) available)
 - rust-lang#98013 (Subtype FRU fields first in `type_changing_struct_update`)
 - rust-lang#98191 (Remove the rest of unnecessary `to_string`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7eabfb5 into rust-lang:master Jun 17, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 17, 2022
@ChrisDenton ChrisDenton deleted the dont-panic branch June 17, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels

O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ChrisDenton @rust-highfive @JohnTitor @bors @kennytm @rustbot