Skip to content

Stabilize scoped threads.#97992

Merged
bors merged 1 commit intorust-lang:masterfrom
m-ou-se:stabilize-scoped-threads
Jun 12, 2022
Merged

Stabilize scoped threads.#97992
bors merged 1 commit intorust-lang:masterfrom
m-ou-se:stabilize-scoped-threads

Conversation

@m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jun 11, 2022 •
edited
Loading

Tracking issue: #93203

FCP finished here: #93203 (comment)

@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 11, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 11, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 11, 2022

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2022
@m-ou-se m-ou-se mentioned this pull request Jun 11, 2022
Closed
10 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se m-ou-se force-pushed the stabilize-scoped-threads branch from 5477de1 to ae0a533 Compare June 11, 2022 13:01
@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 12, 2022
@joshtriplett
Copy link
Member

joshtriplett commented Jun 12, 2022

LGTM!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 12, 2022

📌 Commit ae0a533 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 12, 2022
@Dylan-DPC
Rollup merge of rust-lang#97992 - m-ou-se:stabilize-scoped-threads, r…
58d0d2e 
…=joshtriplett

Stabilize scoped threads.

Tracking issue: rust-lang#93203

FCP finished here: rust-lang#93203 (comment)
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 12, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 12, 2022
@bors
Auto merge of rust-lang#98025 - Dylan-DPC:rollup-cwt2hb7, r=Dylan-DPC
53305f1 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97921 (additional docs example for replace **all** of str)
 - rust-lang#97970 (Fix Termination impl panic on closed stderr)
 - rust-lang#97991 (Use safer `strip=symbols`-flag for dylibs on macOS)
 - rust-lang#97992 (Stabilize scoped threads.)
 - rust-lang#98012 (`ValuePairs::PolyTraitRefs` should be called "trait"s in type error diagnostics)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a24ca03 into rust-lang:master Jun 12, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 12, 2022
@m-ou-se m-ou-se deleted the stabilize-scoped-threads branch June 13, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kennytm kennytm

Labels

relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

7 participants

@m-ou-se @rust-highfive @rust-log-analyzer @joshtriplett @bors @kennytm @rustbot