Add E0790 as more specific variant of E0283#98028

aticu · 2022-06-12T15:52:35Z

Fixes #81701

I think this should be good to go, there are only two things where I am somewhat unsure:

Is there a better way to get the fully-qualified path for the suggestion? I tried self.tcx.def_path_str, but that didn't seem to always give a correct path for the context.
Should all this be extracted into it's own method or is it fine where it is?

r? @estebank

rust-highfive · 2022-06-12T15:52:38Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

compiler/rustc_error_codes/src/error_codes/E0789.md

compiler/rustc_error_codes/src/error_codes/E0283.md

bors · 2022-06-14T20:36:55Z

☔ The latest upstream changes (presumably #96591) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2022-06-28T06:29:20Z

☔ The latest upstream changes (presumably #98222) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2022-07-02T16:51:33Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

GuillaumeGomez · 2022-07-03T18:11:31Z

The error explanation looks good to me. Let's wait for @estebank for the approval on the compiler change.

bors · 2022-07-05T09:40:14Z

☔ The latest upstream changes (presumably #98910) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2022-07-08T18:21:28Z

☔ The latest upstream changes (presumably #99054) made this pull request unmergeable. Please resolve the merge conflicts.

aticu · 2022-07-10T10:07:15Z

I've slightly changed the structure of the code now in hope to make the diff simpler, but nothing fundamentally changed in case you already started looking into this @estebank

estebank · 2022-07-18T23:46:01Z

@bors r+

bors · 2022-07-18T23:46:03Z

📌 Commit 3bec67f has been approved by estebank

It is now in the queue for this repository.

Add E0789 as more specific variant of E0283 Fixes rust-lang#81701 I think this should be good to go, there are only two things where I am somewhat unsure: - Is there a better way to get the fully-qualified path for the suggestion? I tried `self.tcx.def_path_str`, but that didn't seem to always give a correct path for the context. - Should all this be extracted into it's own method or is it fine where it is? r? `@estebank`

Dylan-DPC · 2022-07-19T06:08:03Z

failed in rollup ci

Dylan-DPC · 2022-07-19T06:08:11Z

@bors r-

aticu · 2022-07-19T08:27:03Z

Rebased and changed the error code to E0790.

Dylan-DPC · 2022-07-19T08:47:12Z

@bors r=estebank

bors · 2022-07-19T08:47:14Z

📌 Commit 38ea235 has been approved by estebank

It is now in the queue for this repository.

…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#98028 (Add E0790 as more specific variant of E0283) - rust-lang#99384 (use body's param-env when checking if type needs drop) - rust-lang#99401 (Avoid `Symbol` to `&str` conversions) - rust-lang#99419 (Stabilize `core::task::ready!`) - rust-lang#99435 (Revert "Stabilize $$ in Rust 1.63.0") - rust-lang#99438 (Improve suggestions for `NonZeroT` <- `T` coercion error) - rust-lang#99441 (Update mdbook) - rust-lang#99453 (:arrow_up: rust-analyzer) - rust-lang#99457 (use `par_for_each_in` in `par_body_owners` and `collect_crate_mono_items`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

compiler-errors · 2022-07-19T18:22:01Z

compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs

+                if let (Some(body_id), Some(ty::subst::GenericArgKind::Type(_))) =
+                    (body_id, subst.map(|subst| subst.unpack()))
+                {
+                    struct FindExprBySpan<'hir> {


I wonder if we could introduce a new ObligationCauseCode that stores the hir id of the ExprKind::Path that this obligation comes from, so we wouldn't need to use this span-based search method.

That sounds like a good idea.

compiler-errors · 2022-07-19T18:23:31Z

src/test/ui/error-codes/E0283.stderr

+help: use a fully-qualified path to a specific available implementation (2 found)
   |
-   = note: cannot satisfy `_: Generator`
+LL |     let cont: u32 = <::Impl as Generator>::create();


This ::Impl path is kinda funky, is there a reason we used to_string_no_crate_verbose instead of just tcx.def_path_str?

I don't recall exactly anymore, but if I remember correctly I tried that and got paths as a result that didn't make sense in the context where they were suggested. But I could have made a mistake then. If you'd like I could try it again when I find the time and make a follow-up PR with that or at least find out why it didn't work in this case.

Yeah, either put up a follow up or I can also look into it.

(I was involved in the development of this PR)
I think it was along the lines of it returning Impl instead of the context-sensitive value inner::Impl in the case of nested modules.

compiler-errors · 2022-07-19T18:24:41Z

@aticu, does this fix address #98938 as well?

aticu · 2022-07-19T21:31:21Z

@compiler-errors Yes, this does fix #98938 as well, I just double checked. The resulting error message in that case is

error[E0790]: cannot call associated function on trait without specifying the corresponding `impl` type
 --> test.rs:6:5
  |
2 |     fn bar() {}
  |     ----------- `Foo::bar` defined here
...
6 |     Foo::bar();
  |     ^^^^^^^^ cannot call associated function of trait

rust-highfive assigned estebank Jun 12, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 12, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2022

aticu force-pushed the master branch from 2651708 to 321a96e Compare June 12, 2022 16:23

GuillaumeGomez reviewed Jun 12, 2022

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0789.md Outdated Show resolved Hide resolved

GuillaumeGomez reviewed Jun 12, 2022

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0789.md Outdated Show resolved Hide resolved

eggyal suggested changes Jun 12, 2022

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0283.md Outdated Show resolved Hide resolved

compiler/rustc_error_codes/src/error_codes/E0283.md Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

eggyal suggested changes Jun 13, 2022

View reviewed changes

compiler/rustc_error_codes/src/error_codes/E0283.md Outdated Show resolved Hide resolved

aticu force-pushed the master branch from f0b9e38 to 34a79e6 Compare June 13, 2022 08:57

aticu force-pushed the master branch from 34a79e6 to 6a84965 Compare June 15, 2022 14:32

aticu force-pushed the master branch from 6a84965 to 4bf0cbb Compare July 2, 2022 16:51

GuillaumeGomez approved these changes Jul 3, 2022

View reviewed changes

aticu force-pushed the master branch from 4bf0cbb to e5ed0e0 Compare July 8, 2022 15:05

aticu force-pushed the master branch from e5ed0e0 to 3bec67f Compare July 10, 2022 08:43

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2022

Dylan-DPC mentioned this pull request Jul 19, 2022

Rollup of 8 pull requests #99450

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2022

aticu added 2 commits July 19, 2022 10:16

Add E0790 as more specific variant of E0283

1cbacc0

Don't use main; improve example

38ea235

aticu force-pushed the master branch from 3bec67f to 38ea235 Compare July 19, 2022 08:24

aticu changed the title ~~Add E0789 as more specific variant of E0283~~ Add E0790 as more specific variant of E0283 Jul 19, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2022

matthiaskrgr mentioned this pull request Jul 19, 2022

Rollup of 9 pull requests #99462

Merged

bors merged commit bfefd58 into rust-lang:master Jul 19, 2022

rustbot added this to the 1.64.0 milestone Jul 19, 2022

compiler-errors reviewed Jul 19, 2022

View reviewed changes

aticu mentioned this pull request Jul 19, 2022

Calling a trait method as a free function yields odd diagnostics #98938

Closed

Uh oh!

Conversation

aticu commented Jun 12, 2022

Uh oh!

rust-highfive commented Jun 12, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

bors commented Jun 14, 2022

Uh oh!

bors commented Jun 28, 2022

Uh oh!

rustbot commented Jul 2, 2022

Uh oh!

GuillaumeGomez commented Jul 3, 2022

Uh oh!

bors commented Jul 5, 2022

Uh oh!

bors commented Jul 8, 2022

Uh oh!

aticu commented Jul 10, 2022

Uh oh!

estebank commented Jul 18, 2022

Uh oh!

bors commented Jul 18, 2022

Uh oh!

Dylan-DPC commented Jul 19, 2022

Uh oh!

Dylan-DPC commented Jul 19, 2022

Uh oh!

aticu commented Jul 19, 2022

Uh oh!

Dylan-DPC commented Jul 19, 2022

Uh oh!

bors commented Jul 19, 2022

Uh oh!

compiler-errors Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

estebank Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

compiler-errors Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

aticu Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

compiler-errors Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

davidkna Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Jul 19, 2022

Uh oh!

aticu commented Jul 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants