Merged
Conversation
…m position that originates in macros
…bank Do not suggest adding semicolon/changing delimiters for macros in item position that originates in macros Fixes rust-lang#91800.
Make `std::mem::needs_drop` accept `?Sized` This change attempts to make `needs_drop` work with types like `[u8]` and `str`. This enables code in types like `Arc<T>` that was not possible before, such as rust-lang#97676.
…=m-ou-se Test NLL fix of bad lifetime inference for reference captured in closure. This came up as a use-case for `thread::scope` API that only compiles successfully since `feature(nll)` got stabilized recently. Closes rust-lang#93203 which had been re-opened for tracking this very test case to be added.
…9, r=matthiaskrgr Add rustdoc-json regression test for rust-lang#98009 Fixes rust-lang#98009. There was apparently nothing to be done... cc `@matthiaskrgr` r? `@notriddle`
Keyword docs: Link to wikipedia article for dynamic dispatch
rustbot
added
T-compiler
Member
Author
|
@bors r+ p=5 rollup=never |
Collaborator
|
📌 Commit 6ac9318 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (349bda2): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
std::mem::needs_dropaccept?Sized#97675 (Makestd::mem::needs_dropaccept?Sized)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup