Merged
Conversation
Contributor
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
notriddle
reviewed
Jun 18, 2022
GuillaumeGomez
force-pushed
the
weird-js-condition
branch
from
52935fc to
5fef77d
Compare
Member
Author
|
I simply removed the condition since it was useless. No changes in behaviour. |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 5fef77d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#97511 (Don't build the compiler before building rust-demangler) - rust-lang#98165 (once cell renamings) - rust-lang#98207 (Update cargo) - rust-lang#98229 (Add new eslint checks) - rust-lang#98230 (Fix weird js condition) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going around the code, I found this weird condition. Fixing also affects the generated results in some cases apparently (could only find this one).
Any idea maybe @notriddle?
r? @notriddle