Remove MAX_SUGGESTION_HIGHLIGHT_LINES

[WaffleLapkin]

After #97798 the MAX_SUGGESTION_HIGHLIGHT_LINES constant doesn't really make sense since we always show full suggestions. This PR removes last usages of the constant and the constant itself.

r? @flip1995 (this mostly does changes in clippy)

[rust-highfive]

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

[flip1995]

Great! So removing those extra checks from Clippy seemed to just have worked. Only a small comment.

[flip1995]

Those lines are probably there in order to test that also with more than 6 lines the message is displayed correctly. Can you add those back an re-bless the tests?

[WaffleLapkin]

That's weird, because I didn't actually change anything here, the original file doesn't have these too:

rust/src/tools/clippy/tests/ui/map_flatten_fixable.rs

Lines 56 to 67 in 10f4ce3

	fn issue8878() {
	std::collections::HashMap::<u32, u32>::new()
	.get(&0)
	.map(|_| {
	// we need some newlines
	// so that the span is big enough
	// for a splitted output of the diagnostic
	Some("")
	// whitespace beforehand is important as well
	})
	.flatten();
	}

These were removed by x test clippy --bless

[WaffleLapkin]

The commit that added this test, rust-lang/rust-clippy@22673bc for some reason has more comments in the .fixed file, than in the .rs file.

[flip1995]

Oh so this was a bug before, but this PR now fixed that bug. Awesome! Thanks for pointing this out.

[flip1995]

To remove the constant was already agreed on in #97798 AFAICT

Everything else are Clippy changes, so it shouldn't be a problem if I approve this PR myself.

@bors r+

Thanks!

[bors]

📌 Commit ffb593b has been approved by flip1995