Merged
Conversation
Signed-off-by: Yuki Okushi <[email protected]>
Arms are about TAIT and RPIT, as the variants clearly show.
lub: don't bail out due to empty binders
allows for the following to compile. The equivalent code using `struct Wrapper<'upper>(fn(&'upper ());` already compiles on stable.
```rust
let _: fn(&'upper ()) = match v {
true => lt_in_fn::<'a>(),
false => lt_in_fn::<'b>(),
};
```
see https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=7034a677190110941223cafac6632f70 for a complete example
r? ```@rust-lang/types```
…li-obk interpret: convert_tag_add_extra: allow tagger to raise errors Needed for rust-lang/miri#2234 r? `@oli-obk`
Move some tests to more reasonable directories r? `@petrochenkov`
…rrors Add a full regression test for rust-lang#73727 Closes rust-lang#73727 This also moves a test to the `issues` directory as it's also tested on the adt_const_params feature. r? ```@compiler-errors``` Signed-off-by: Yuki Okushi <[email protected]>
…t, r=GuillaumeGomez Remove the unused-`#[doc(hidden)]` logic from the `unused_attributes` lint Fixes rust-lang#96890. It was found out that `#[doc(hidden)]` on trait impl items does indeed have an effect on the generated documentation (see the linked issue). In my opinion and the one of [others](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Validy.20checks.20for.20.60.23.5Bdoc.28hidden.29.5D.60/near/281846219), rustdoc's output is actually a bit flawed in that regard but that should be tracked in a new issue I suppose (I will open an issue for that in the near future). The check was introduced in rust-lang#96008 which is marked to be part of version `1.62` (current `beta`). As far as I understand, this means that **this PR needs to be backported** to `beta` to fix rust-lang#96890 on time. Correct me if I am wrong. CC `@dtolnay` (in case you would like to agree or disagree with my decision to fully remove this check) `@rustbot` label A-lint T-compiler T-rustdoc r? `@rust-lang/compiler`
…t, r=oli-obk This comment is out dated and misleading, the arm is about TAITs r? ```@oli-obk``` ```@oli-obk``` unsure if you want to add a different comment of some sort. ```@bors``` rollup=always
rustbot
added
T-compiler
Member
Author
|
@bors r+ p=6 rollup=never |
Collaborator
|
📌 Commit cb3322a has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 22, 2022
Tested on commit rust-lang/rust@a09c668. Direct link to PR: <rust-lang/rust#98359> 💔 miri on windows: test-pass → build-fail (cc @RalfJung @eddyb @oli-obk). 💔 miri on linux: test-pass → build-fail (cc @RalfJung @eddyb @oli-obk).
Collaborator
|
Finished benchmarking commit (a09c668): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
Member
rustbot
added
the
perf-regression-triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
&'static [_]causes ICE #73727)#[doc(hidden)]logic from theunused_attributeslint #98336 (Remove the unused-#[doc(hidden)]logic from theunused_attributeslint)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup