Skip to content

Factor out hir::Node::Binding#98639

Merged
bors merged 1 commit intorust-lang:masterfrom
camsteffen:no-node-binding
Jul 2, 2022
Merged

Factor out hir::Node::Binding#98639
bors merged 1 commit intorust-lang:masterfrom
camsteffen:no-node-binding

Conversation

@camsteffen
Copy link
Contributor

@camsteffen camsteffen commented Jun 28, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 28, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 28, 2022

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2022
camsteffen
camsteffen commented Jun 28, 2022
View reviewed changes
@compiler-errors
Copy link
Contributor

compiler-errors commented Jun 28, 2022

@camsteffen do you mind fixing the tidy failure and rebasing? https://github.com/rust-lang/rust/runs/7099501730?check_suite_focus=true#step:25:2212

also did you bless the ui tests? curious if this changed any diagnostics outputs.

@camsteffen
Copy link
Contributor Author

camsteffen commented Jun 28, 2022

My bad. Fixed tidy and rebased. Didn't run the ui tests since I'm hoping they just pass.

@compiler-errors
Copy link
Contributor

compiler-errors commented Jun 28, 2022

I can take a look at this after my real day job is over 😜.

@compiler-errors
Copy link
Contributor

compiler-errors commented Jun 30, 2022

Looks good to me.

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 30, 2022

📌 Commit 716af21 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 30, 2022
@Dylan-DPC
Rollup merge of rust-lang#98639 - camsteffen:no-node-binding, r=compi…
4df9604 
…ler-errors

Factor out `hir::Node::Binding`
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 30, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2022
@matthiaskrgr
Rollup merge of rust-lang#98639 - camsteffen:no-node-binding, r=compi…
1a9051e 
…ler-errors

Factor out `hir::Node::Binding`
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 30, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 30, 2022
Merged
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Jun 30, 2022

This will need a rebase once #98706 is merged, can't merge both PRs at a time due to compiler error: #98723 (comment)

I'm gonna @bors r- to get this out of the queue for now, feel free to re-r+ once rebase is done.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 30, 2022
camsteffen
camsteffen commented Jul 1, 2022
View reviewed changes
src/tools/clippy/clippy_lints/src/manual_rem_euclid.rs
&& const1 == const2 && const2 == const3
&& let Some(hir_id) = path_to_local(expr3)
&& let Some(Node::Binding(_)) = cx.tcx.hir().find(hir_id) {
&& let Some(hir_id) = path_to_local(expr3) {
Copy link
Contributor Author

@camsteffen camsteffen Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New change with rebase. path_to_local is always a binding.

@camsteffen
Copy link
Contributor Author

camsteffen commented Jul 1, 2022

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jul 1, 2022

📌 Commit ec82bc1 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2022
@bors
Auto merge of rust-lang#98802 - Dylan-DPC:rollup-u6mwx27, r=Dylan-DPC
aedf78e 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98639 (Factor out `hir::Node::Binding`)
 - rust-lang#98653 (Add regression test for rust-lang#79494)
 - rust-lang#98763 (bootstrap: illumos platform flags for split-debuginfo)
 - rust-lang#98766 (cleanup mir visitor for `rustc::pass_by_value`)
 - rust-lang#98783 (interpret: make a comment less scary)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d287726 into rust-lang:master Jul 2, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 2, 2022
@camsteffen camsteffen deleted the no-node-binding branch July 2, 2022 12:12
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 18, 2022
@Dylan-DPC
Rollup merge of rust-lang#98639 - camsteffen:no-node-binding, r=compi…
053caf8 
…ler-errors

Factor out `hir::Node::Binding`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

6 participants

@camsteffen @rustbot @rust-highfive @compiler-errors @bors @matthiaskrgr