only run --all-targets in stage0 for Std

[jo3bingham]

Repro'd the issue with python3 x.py check --stage 1 library/std and tested the fix with the same command.

r? @jyn514

I tried to implement this solution, but didn't have any luck. I don't think I fully understood what needed to be done. However, I would love to be mentored on it since it would be a more correct solution, and I can learn more about how bootstrap works.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jyn514 (or someone else) soon.

Please see the contribution instructions for more information.

[jyn514]

I tried to implement this solution, but didn't have any luck.

When you say didn't have luck, you mean it didn't fix the problem? Or you didn't understand it well enough to write code for it?

I think the code should be fairly simple, basically copy those two lines immediately before --all-targets.

[jo3bingham]

When you say didn't have luck, you mean it didn't fix the problem? Or you didn't understand it well enough to write code for it?

I think the code should be fairly simple, basically copy those two lines immediately before --all-targets.

I wasn't sure if it was because I didn't understand it well enough or just that it didn't fix the problem, but I did copy those two lines before --all-targets and the errors were the same for me as it was without it:

builder.ensure(crate::compile::Std::new(compiler, compiler.host));
builder.ensure(crate::compile::Std::new(compiler, target));
cargo.arg("--all-targets");

error: could not compile `getrandom` due to 125 previous errors
error: could not compile `test` due to 566 previous errors
error: could not compile `proc_macro` due to 552 previous errors

EDIT:
I was mistaken, the errors I get from adding those two lines are different. Sample error and logs:

error: duplicate lang item in crate `core` (which `rustc_std_workspace_core` depends on): `sized`.
  |
  = note: the lang item is first defined in crate `core` (which `getrandom` depends on)
  = note: first definition in `core` loaded from \\?\C:\Users\joe.bingham\Documents\GitHub\rust\build\x86_64-pc-windows-msvc\stage1\lib\rustlib\x86_64-pc-windows-msvc\lib\libcore-62524b6728766064.rlib
  = note: second definition in `core` loaded from \\?\C:\Users\joe.bingham\Documents\GitHub\rust\build\x86_64-pc-windows-msvc\stage1-std\x86_64-pc-windows-msvc\release\deps\libcore-94a2db40080734a4.rmeta

log.txt

[jyn514]

I was mistaken, the errors I get from adding those two lines are different. Sample error and logs:

Is this with or without calling add_to_sysroot? you can only do one or the other, calling add_to_sysroot and ensure(compile::Std) will lead to errors.

[jo3bingham]

@rustbot label -S-waiting-on-author +S-waiting-on-review

[jyn514]

👍 this seems good to me - it works around the error, and it seems exceedingly rare to want to check std tests compile without actually running them (in stage1, no less).

@bors r+ rollup

[bors]

📌 Commit c5d661a has been approved by jyn514

It is now in the queue for this repository.