Breakup the building chapter#491
Merged
mark-i-m merged 2 commits intorust-lang:masterfrom Nov 6, 2019
Merged
Conversation
JohnTitor
approved these changes
Nov 5, 2019
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Seems the content is unchanged, I'm going to approve this.
Contributor
Author
|
Yes, I added a few filler/intro sentences, but the content is unchanged |
Contributor
Author
|
Do you feel it is an improvement? |
Member
|
I agree with this change since I feel "How to Build and Run the Compiler" chapter is long. |
Contributor
Author
|
Cool :) Thanks @JohnTitor @amanjeev ! |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 6, 2019
Fix broken link in README The link to the rustc guide on building and running the compiler is broken. It was broken in [rustc-guide#491](rust-lang/rustc-dev-guide#491).
This was referenced Nov 6, 2019
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 7, 2019
Fix broken link in README The link to the rustc guide on building and running the compiler is broken. It was broken in [rustc-guide#491](rust-lang/rustc-dev-guide#491).
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 7, 2019
Update link on CONTRIBUTING.md This is a lost article of rust-lang#66162 Follow-up for rust-lang/rustc-dev-guide#491 CC: @mark-i-m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR breaks up the giant "How to Build and Run the Compiler" chapter into a few subchapters: