Add section describing git hook functionality#848
Merged
jyn514 merged 1 commit intorust-lang:masterfrom Oct 8, 2020
caass:patch-1
Merged
Add section describing git hook functionality#848jyn514 merged 1 commit intorust-lang:masterfrom caass:patch-1
jyn514 merged 1 commit intorust-lang:masterfrom
caass:patch-1
Conversation
jyn514
reviewed
Oct 5, 2020
jyn514
reviewed
Oct 6, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 6, 2020
Add a command to install a git hook to automatically run `x.py test tidy --bless` Some folks (such as myself) would probably find a lot of convenience in a pre-commit hook that automatically runs tidy before committing, to avoid burning CI time learning that your commit wasn't tidy. I'm absolutely positive I have missed some stuff. I basically just got this to where you can run `./x.py run install-git-hook` and then clicked the commit button. Please let me know what else you'd like me to add before this can be merged! [rustc-dev-guide companion PR](rust-lang/rustc-dev-guide#848)
Member
|
I believe this is no longer blocked, so I'm removing the label. @rustbot modify labels: -blocked |
jyn514
approved these changes
Oct 7, 2020
Member
|
@jyn514 Nit is fixed! @caass Could you squash your commits? |
camelid
reviewed
Oct 8, 2020
Member
camelid
left a comment
camelid
left a comment
There was a problem hiding this comment.
Oops, I have a few more nits. But they're not a big deal if you just want to get this merged :)
Contributor
Author
|
@camelid no by all means! i'll fix them and pending anything else squash :) |
This is a companion to [this PR](rust-lang/rust#76356), which deals with including functionality for automatically running `tidy --bless` on each commit. Undo editor auto-formatting and clarify git hook renaming a word Phrasing Apply suggestions from code review Co-authored-by: Camelid <37223377+camelid@users.noreply.github.com>
spikespaz
pushed a commit
to spikespaz/dotwalk-rs
that referenced
this pull request
Aug 29, 2024
Add a command to install a git hook to automatically run `x.py test tidy --bless` Some folks (such as myself) would probably find a lot of convenience in a pre-commit hook that automatically runs tidy before committing, to avoid burning CI time learning that your commit wasn't tidy. I'm absolutely positive I have missed some stuff. I basically just got this to where you can run `./x.py run install-git-hook` and then clicked the commit button. Please let me know what else you'd like me to add before this can be merged! [rustc-dev-guide companion PR](rust-lang/rustc-dev-guide#848)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion to this PR, which deals with including functionality for automatically running
tidy --blesson each commit.